From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dannenberg, Andreas <dannenberg@ti.com>
Date: Fri, 10 Jun 2016 11:39:46 -0500
Subject: [U-Boot] [PATCH] ARM: AM437x: Enable FIT for hs platforms
In-Reply-To: <7EA653B77D37124996A03FC4ADE6D59E758FAF89@DBDE04.ent.ti.com>
References: <7EA653B77D37124996A03FC4ADE6D59E758FAF89@DBDE04.ent.ti.com>
Message-ID: <20160610163946.GI10708@borg.dal.design.ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Madan,
comments inlined...

On Fri, Jun 10, 2016 at 11:32:31AM -0500, Srinivas, Madan wrote:
> Adding FIT support to the SPL and u-boot for AM437x HS devices.
> 
>  
> 
> Signed-off-by: Madan Srinivas <madans@ti.com>
> 
> ---
> 
> configs/am437x_hs_evm_defconfig | 6 +++++-
> 
> 1 file changed, 5 insertions(+), 1 deletion(-)
> 
>  
> 
> diff --git a/configs/am437x_hs_evm_defconfig b/configs/am437x_hs_evm_defconfig
> 
> index 3cd39eb..fac06a7 100644
> 
> --- a/configs/am437x_hs_evm_defconfig
> 
> +++ b/configs/am437x_hs_evm_defconfig
> 
> @@ -10,7 +10,9 @@ CONFIG_DEFAULT_DEVICE_TREE="am437x-gp-evm"
> 
> CONFIG_SPL=y
> 
> CONFIG_ISW_ENTRY_ADDR=0x40302ae0
> 
> CONFIG_SPL_STACK_R=y
> 
> -CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=1"
> 
> +CONFIG_FIT=y
> 
> +CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=1,NAND"

I didn't look deeper but shouldn't adding "NAND" be a separate patch?
It has nothing to do with FIT has it?

Also for some reason your patch shows up with double-line feeds which is
odd.

Regards,

--
Andreas Dannenberg
Texas Instruments Inc



> 
> +CONFIG_SPL_LOAD_FIT=y
> 
> CONFIG_HUSH_PARSER=y
> 
> CONFIG_CMD_BOOTZ=y
> 
> # CONFIG_CMD_IMLS is not set
> 
> @@ -33,6 +35,7 @@ CONFIG_CMD_EXT4_WRITE=y
> 
> CONFIG_CMD_FAT=y
> 
> CONFIG_CMD_FS_GENERIC=y
> 
> CONFIG_OF_CONTROL=y
> 
> +CONFIG_OF_LIST="am437x-gp-evm"
> 
> CONFIG_DM=y
> 
> CONFIG_DM_MMC=y
> 
> CONFIG_SPI_FLASH=y
> 
> @@ -53,3 +56,4 @@ CONFIG_USB_GADGET_DOWNLOAD=y
> 
> CONFIG_G_DNL_MANUFACTURER="Texas Instruments"
> 
> CONFIG_G_DNL_VENDOR_NUM=0x0403
> 
> CONFIG_G_DNL_PRODUCT_NUM=0xbd00
> 
> +CONFIG_SPL_OF_LIBFDT=y
> 
> --
> 
> 1.9.1
> 
>  
>