From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/9] libfdt: Add new headers and defines
Date: Mon, 13 Jun 2016 11:28:28 +0200 [thread overview]
Message-ID: <20160613092828.GE4481@lukather> (raw)
In-Reply-To: <20160611103035.GW9226@voom.fritz.box>
Hi David,
On Sat, Jun 11, 2016 at 08:30:35PM +1000, David Gibson wrote:
> On Fri, Jun 10, 2016 at 05:03:36PM +0300, Pantelis Antoniou wrote:
> > Hi Maxime,
> >
> > > On May 27, 2016, at 12:13 , Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
> > >
> > > The libfdt overlay support introduces a bunch of new includes and
> > > functions.
> > >
> > > Make sure we are able to build it by adding the needed glue.
> > >
> > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > > ---
> > > include/libfdt_env.h | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/include/libfdt_env.h b/include/libfdt_env.h
> > > index 273b5d30f867..2d2196031332 100644
> > > --- a/include/libfdt_env.h
> > > +++ b/include/libfdt_env.h
> > > @@ -23,6 +23,13 @@ typedef __be64 fdt64_t;
> > > #define fdt64_to_cpu(x) be64_to_cpu(x)
> > > #define cpu_to_fdt64(x) cpu_to_be64(x)
> > >
> > > +#ifdef __UBOOT__
> > > +#include "malloc.h"
> > > +#include "vsprintf.h"
> > > +
> > > +#define strtol(cp, endp, base) simple_strtol(cp, endp, base)
> > > +#endif
> > > +
> > > /* adding a ramdisk needs 0x44 bytes in version 2008.10 */
> > > #define FDT_RAMDISK_OVERHEAD 0x80
> > >
> >
> > We need to figure out what the upstream libfdt/dtc maintainer?s take is on this is.
> > For u-boot we?re fine and for now it?s OK.
>
> These were sent to the upstream dtc list as well.
>
> The concept is fine, but there are a number of problems in the
> implementation. I sent detailed review comments on the upstream
> versions, haven't seen a respin yet.
Yes, thanks a lot for your comments, I'll address them and resend a
new serie.
(it might not be before a couple of weeks though).
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160613/482334b7/attachment.sig>
next prev parent reply other threads:[~2016-06-13 9:28 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 9:13 [U-Boot] [PATCH v2 0/9] cmd: fdt: Add device tree overlays support Maxime Ripard
2016-05-27 9:13 ` [U-Boot] [PATCH v2 1/9] cmd: fdt: Narrow the check for fdt addr Maxime Ripard
2016-06-10 0:34 ` Simon Glass
2016-06-10 13:55 ` Pantelis Antoniou
2016-05-27 9:13 ` [U-Boot] [PATCH v2 2/9] scripts: Makefile.lib: Sanitize DTB names Maxime Ripard
2016-06-10 0:34 ` Simon Glass
2016-06-10 13:59 ` Pantelis Antoniou
2016-05-27 9:13 ` [U-Boot] [PATCH v2 3/9] vsprintf: Include stdarg for va_list Maxime Ripard
2016-06-10 0:34 ` Simon Glass
2016-06-10 14:00 ` Pantelis Antoniou
2016-05-27 9:13 ` [U-Boot] [PATCH v2 4/9] libfdt: Add new headers and defines Maxime Ripard
2016-06-10 0:34 ` Simon Glass
2016-06-10 14:03 ` Pantelis Antoniou
2016-06-11 10:30 ` David Gibson
2016-06-13 9:28 ` Maxime Ripard [this message]
2016-06-16 0:39 ` Simon Glass
2016-05-27 9:13 ` [U-Boot] [PATCH v2 5/9] libfdt: Add iterator over properties Maxime Ripard
2016-06-10 2:51 ` Stefan Agner
2016-06-10 14:04 ` Pantelis Antoniou
2016-06-13 9:35 ` Maxime Ripard
2016-05-27 9:13 ` [U-Boot] [PATCH v2 6/9] libfdt: Add max phandle retrieval function Maxime Ripard
2016-06-10 2:55 ` Stefan Agner
2016-06-10 15:13 ` Pantelis Antoniou
2016-05-27 9:13 ` [U-Boot] [PATCH v2 7/9] libfdt: Add overlay application function Maxime Ripard
2016-06-10 3:38 ` Stefan Agner
2016-06-10 14:28 ` Pantelis Antoniou
2016-06-13 9:51 ` Maxime Ripard
2016-06-14 0:25 ` David Gibson
2016-06-14 9:22 ` Pantelis Antoniou
2016-06-15 3:14 ` David Gibson
2016-06-15 9:34 ` Pantelis Antoniou
2016-06-15 10:19 ` David Gibson
2016-06-15 10:23 ` Pantelis Antoniou
2016-06-15 14:49 ` Warner Losh
2016-05-27 9:13 ` [U-Boot] [PATCH v2 8/9] cmd: fdt: add fdt overlay application subcommand Maxime Ripard
2016-06-10 0:34 ` Simon Glass
2016-06-10 3:45 ` Stefan Agner
2016-06-10 13:56 ` Pantelis Antoniou
2016-05-27 9:13 ` [U-Boot] [PATCH v2 9/9] tests: Introduce DT overlay tests Maxime Ripard
2016-06-10 0:34 ` Simon Glass
2016-06-10 15:20 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613092828.GE4481@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox