From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Wed, 15 Jun 2016 10:36:41 +0200 Subject: [U-Boot] [PATCH v2 5/5] fastboot: sparse: improve CHUNK_TYPE_FILL write performance In-Reply-To: <1465323579-18928-6-git-send-email-srae@broadcom.com> References: <1465323579-18928-1-git-send-email-srae@broadcom.com> <1465323579-18928-6-git-send-email-srae@broadcom.com> Message-ID: <20160615083641.GR9354@lukather> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jun 07, 2016 at 11:19:39AM -0700, Steve Rae wrote: > - increase the size of the fill buffer > - testing has shown a 10x improvement when the sparse image > has large CHUNK_TYPE_FILL chunks > > Signed-off-by: Steve Rae > --- > > Changes in v2: None > > common/image-sparse.c | 37 +++++++++++++++++++++++++++---------- > 1 file changed, 27 insertions(+), 10 deletions(-) > > diff --git a/common/image-sparse.c b/common/image-sparse.c > index 9632c6f..ddf5772 100644 > --- a/common/image-sparse.c > +++ b/common/image-sparse.c > @@ -1,4 +1,3 @@ > - > /* > * Copyright (c) 2009, Google Inc. > * All rights reserved. > @@ -46,6 +45,10 @@ > > #include > > +#ifndef CONFIG_FASTBOOT_FLASH_FILLBUF_SIZE > +#define CONFIG_FASTBOOT_FLASH_FILLBUF_SIZE (1024 * 512) I wonder whether that would be better to just put the number of blocks there. NAND blocks are much larger than MMC's, so the gain benefit might not be even. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: