From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nikita Kiryanov <nikita@compulab.co.il>
Date: Wed, 15 Jun 2016 18:15:51 +0300
Subject: [U-Boot] [PATCH] ARM: board: cm-fx6: fix mmc for old revisions
	of utilite
In-Reply-To: <d0e15b3c121b416fb280605ee1bd1800@rwthex-s1-b.rwth-ad.de>
References: <d0e15b3c121b416fb280605ee1bd1800@rwthex-s1-b.rwth-ad.de>
Message-ID: <20160615151551.GA2833@arkadi-linux.compulab.local>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi CHristopher,

On Wed, Jun 08, 2016 at 09:02:36PM +0200, Christopher Spinrath wrote:
> Old revisions of Utilite (based on cmfx6) do not have a dedicated
> card detect pin. But the card is removable by the user and card
> detection can be realized with polling (e.g. supported by Linux).
> 
> Add the broken-cd property to the mmc device tree instead of the
> non-removable property to make card detection possible if polling
> is supported.

Acked-by: Nikita Kiryanov <nikita@compulab.co.il>
One nit-pick below:

> 
> Fixes: 41855186afd3 ("arm: mx6: cm-fx6: modify device tree for old revisions of utilite")

This isn't technically a fix; you're enabling new functionality. The
original behavior wasn't buggy, it just lacked the card detect feature.

> Signed-off-by: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
> ---
>  board/compulab/cm_fx6/cm_fx6.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> -- 
> 2.8.3
>

Regards,
Nikita Kiryanov