From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dm: ehci-mx6: support driver model
Date: Mon, 20 Jun 2016 09:45:33 +0800 [thread overview]
Message-ID: <20160620014531.GA1450@linux-7smt.suse> (raw)
In-Reply-To: <CAPnjgZ2nMefpHmTjaPj+QnLXSopakdStU1OyAVphxN=hTVWPnA@mail.gmail.com>
Hi Simon,
On Fri, Jun 17, 2016 at 04:59:49PM -0600, Simon Glass wrote:
>Hi Peng,
>
>On 17 June 2016 at 00:19, Peng Fan <van.freenix@gmail.com> wrote:
>> Support driver model for ehci mx6 driver.
>> Consolidate code to be shared between DM and non-DM, such as
>> introducing ehci_mx6_common_init.
>> For simplicity, some old fasion code are keeped for DM usage,
>> such as board_ehci_power and board_usb_phy_mode. And 'dr-mode',
>> usbphy and vbus handling code for DM is not added now.
>> These will be added in future patches.
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> Cc: Marek Vasut <marex@denx.de>
>> Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
>> Cc: Stefan Agner <stefan@agner.ch>
>> Cc: Simon Glass <sjg@chromium.org>
>> ---
>> drivers/usb/host/ehci-mx6.c | 144 +++++++++++++++++++++++++++++++++++++++-----
>> 1 file changed, 130 insertions(+), 14 deletions(-)
>
>Reviewed-by: Simon Glass <sjg@chromium.org>
>
>Good start. Do you have a plan to drop the board_...() functions?
Yeah. I'll drop the board_ functions for dt+dm for ehci-mx6 in following
up patches.
Thanks,
Peng.
>
>Regards,
>Simon
next prev parent reply other threads:[~2016-06-20 1:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 6:19 [U-Boot] [PATCH] dm: ehci-mx6: support driver model Peng Fan
2016-06-17 22:59 ` Simon Glass
2016-06-18 0:44 ` Marek Vasut
2016-06-20 1:45 ` Peng Fan [this message]
2016-09-29 12:08 ` Jagan Teki
2016-10-08 1:57 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620014531.GA1450@linux-7smt.suse \
--to=van.freenix@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox