From: Andreas Dannenberg <dannenberg@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] kbuild: avoid race between dtbs and dt/dt.dtb targets
Date: Thu, 23 Jun 2016 08:22:13 -0500 [thread overview]
Message-ID: <20160623132213.GS26355@borg.dal.design.ti.com> (raw)
In-Reply-To: <1466657626-9328-1-git-send-email-yamada.masahiro@socionext.com>
On Thu, Jun 23, 2016 at 01:53:46PM +0900, Masahiro Yamada wrote:
> If the final targets depend on both "dtbs" and "dts/dt.dtb",
> and -j option is given to the command line, multiple threads
> descend into the dts/ directory, which causes build error.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Tested-by: Andreas Dannenberg <dannenberg@ti.com>
Yamada-san,
thanks, this patch is fantastic! It fixes the issue discussed under [1]
(no longer need to suppress parallel DTC compiles) and also avoids the
general double-compile of the DTC files that happened with my patch
series. Tested it on a few TI ARMv7 OMAP-type EVMs and did not see any
adverse effects.
Regards,
--
Andreas Dannenberg
Texas Instruments Inc
[1] https://www.mail-archive.com/u-boot at lists.denx.de/msg217010.html
> ---
>
> Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index d0e7a8a..ad434c7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -810,7 +810,9 @@ ifeq ($(CONFIG_DM_I2C_COMPAT),y)
> endif
>
> PHONY += dtbs
> -dtbs dts/dt.dtb: checkdtc u-boot
> +dtbs: dts/dt.dtb
> + @:
> +dts/dt.dtb: checkdtc u-boot
> $(Q)$(MAKE) $(build)=dts dtbs
>
> quiet_cmd_copy = COPY $@
> --
> 1.9.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
next prev parent reply other threads:[~2016-06-23 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 4:53 [U-Boot] [PATCH] kbuild: avoid race between dtbs and dt/dt.dtb targets Masahiro Yamada
2016-06-23 13:22 ` Andreas Dannenberg [this message]
2016-06-25 2:53 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623132213.GS26355@borg.dal.design.ti.com \
--to=dannenberg@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox