From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/4] usb: ums: support multiple controllers using controller_index
Date: Thu, 23 Jun 2016 16:44:37 +0200 [thread overview]
Message-ID: <20160623164437.412de870@amdc2363> (raw)
In-Reply-To: <1465204596-6637-2-git-send-email-rajat.srivastava@nxp.com>
Hi Rajat,
First of all, sorry for late reply. I was not in the office.
> From: Rajesh Bhagat <rajesh.bhagat@nxp.com>
>
> Adds a new field in fsg_common namely controller_index to support
> multiple controllers usb gadget support.
>
> Signed-off-by: Rajat Srivastava <rajat.srivastava@nxp.com>
> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
> ---
> Changes for v2:
> - Changes type of fsg_main_thread argument to unsigned int
>
> cmd/usb_mass_storage.c | 2 +-
> drivers/usb/gadget/f_mass_storage.c | 11 +++++++++--
> include/usb_mass_storage.h | 2 +-
> 3 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/cmd/usb_mass_storage.c b/cmd/usb_mass_storage.c
> index b05913a..bf80d37 100644
> --- a/cmd/usb_mass_storage.c
> +++ b/cmd/usb_mass_storage.c
> @@ -214,7 +214,7 @@ int do_usb_mass_storage(cmd_tbl_t *cmdtp, int
> flag, while (1) {
> usb_gadget_handle_interrupts(controller_index);
>
> - rc = fsg_main_thread(NULL);
> + rc = fsg_main_thread(controller_index);
> if (rc) {
> /* Check I/O error */
> if (rc == -EIO)
> diff --git a/drivers/usb/gadget/f_mass_storage.c
> b/drivers/usb/gadget/f_mass_storage.c index 1ecb92a..27ca5fe 100644
> --- a/drivers/usb/gadget/f_mass_storage.c
> +++ b/drivers/usb/gadget/f_mass_storage.c
> @@ -362,6 +362,7 @@ struct fsg_common {
> char inquiry_string[8 + 16 + 4 + 1];
>
> struct kref ref;
> + unsigned int controller_index;
> };
>
> struct fsg_config {
> @@ -691,7 +692,7 @@ static int sleep_thread(struct fsg_common *common)
> k = 0;
> }
>
> - usb_gadget_handle_interrupts(0);
> +
> usb_gadget_handle_interrupts(common->controller_index); }
> common->thread_wakeup_needed = 0;
> return rc;
> @@ -2402,10 +2403,14 @@ static void handle_exception(struct
> fsg_common *common)
> /*-------------------------------------------------------------------------*/
>
> -int fsg_main_thread(void *common_)
> +int fsg_main_thread(unsigned int controller_index)
> {
> int ret;
> struct fsg_common *common = the_fsg_common;
> +
> + /* update the controller_index */
> + common->controller_index = controller_index;
> +
> /* The main loop */
> do {
> if (exception_in_progress(common)) {
> @@ -2476,6 +2481,7 @@ static struct fsg_common
> *fsg_common_init(struct fsg_common *common,
> common->ops = NULL;
> common->private_data = NULL;
> + common->controller_index = 0;
>
> common->gadget = gadget;
> common->ep0 = gadget->ep0;
> @@ -2770,6 +2776,7 @@ int fsg_add(struct usb_configuration *c)
>
> fsg_common->ops = NULL;
> fsg_common->private_data = NULL;
> + fsg_common->controller_index = 0;
>
> the_fsg_common = fsg_common;
>
> diff --git a/include/usb_mass_storage.h b/include/usb_mass_storage.h
> index 8229f62..f21cc7a 100644
> --- a/include/usb_mass_storage.h
> +++ b/include/usb_mass_storage.h
> @@ -28,6 +28,6 @@ struct ums {
>
> int fsg_init(struct ums *ums_devs, int count);
> void fsg_cleanup(void);
> -int fsg_main_thread(void *);
> +int fsg_main_thread(unsigned int);
> int fsg_add(struct usb_configuration *c);
> #endif /* __USB_MASS_STORAGE_H__ */
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2016-06-23 14:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 9:16 [U-Boot] [PATCH v2 0/4] armv8/fsl-layerscape: add dwc3 gadget driver support Rajat Srivastava
2016-06-06 9:16 ` [U-Boot] [PATCH v2 1/4] usb: ums: support multiple controllers using controller_index Rajat Srivastava
2016-06-23 14:44 ` Lukasz Majewski [this message]
2016-06-06 9:16 ` [U-Boot] [PATCH v2 2/4] usb: dwc3: Add helper functions to enable snooping and burst settings Rajat Srivastava
2016-06-06 12:54 ` Marek Vasut
2016-06-08 9:44 ` Rajesh Bhagat
2016-06-08 13:26 ` Marek Vasut
2016-06-10 0:34 ` Simon Glass
2016-06-14 4:09 ` Rajesh Bhagat
2016-06-17 3:51 ` Simon Glass
2016-07-04 4:33 ` Rajesh Bhagat
2016-06-23 14:53 ` Lukasz Majewski
2016-07-04 4:37 ` Rajesh Bhagat
2016-07-27 17:00 ` york sun
2016-06-06 9:16 ` [U-Boot] [PATCH v2 3/4] armv8/fsl-layerscape: add dwc3 gadget driver support Rajat Srivastava
2016-06-10 0:35 ` Simon Glass
2016-06-14 4:11 ` Rajesh Bhagat
2016-06-23 14:57 ` Lukasz Majewski
2016-07-04 4:37 ` Rajesh Bhagat
2016-07-04 7:18 ` Lukasz Majewski
2016-06-06 9:16 ` [U-Boot] [PATCH v2 4/4] armv8/fsl-layerscape: enable " Rajat Srivastava
2016-06-23 14:57 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623164437.412de870@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox