From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 24 Jun 2016 22:53:14 -0400 Subject: [U-Boot] clk: sandbox: don't check clk ID against 0 In-Reply-To: <20160621193207.12792-1-swarren@wwwdotorg.org> References: <20160621193207.12792-1-swarren@wwwdotorg.org> Message-ID: <20160625025314.GC19080@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jun 21, 2016 at 01:32:07PM -0600, Stephen Warren wrote: > From: Stephen Warren > > clk->id is unsigned, so it can't be < 0. Remove the check for that. > > FWIW, this issue was introduced when the clock API converted e.g. > clk_get_rate()'s clock ID parameter from an int to an unsigned long > (with a struct clk), without removing this check. > > Fixes: 135aa9500264 ("clk: convert API to match reset/mailbox style") > Reported-by: Coverity Scan > Signed-off-by: Stephen Warren > Acked-by: Simon Glass Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: