From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 10/12] libfdt: Add overlay application function
Date: Mon, 27 Jun 2016 09:13:16 +0200 [thread overview]
Message-ID: <20160627071316.GP4000@lukather> (raw)
In-Reply-To: <CAPnjgZ0dg-CX0XAxCirB-xLO2Jf_Q9T7rc5vu2qznDkYwA54ew@mail.gmail.com>
Hi Simon,
On Sat, Jun 25, 2016 at 08:53:58PM -0600, Simon Glass wrote:
> Hi Maxime,
>
> On 24 June 2016 at 08:27, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > The device tree overlays are a good way to deal with user-modifyable
> > boards or boards with some kind of an expansion mechanism where we can
> > easily plug new board in (like the BBB, the Raspberry Pi or the CHIP).
> >
> > Add a new function to merge overlays with a base device tree.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> > include/libfdt.h | 30 ++++
> > lib/Kconfig | 5 +
> > lib/libfdt/Makefile | 2 +
> > lib/libfdt/fdt_overlay.c | 381 +++++++++++++++++++++++++++++++++++++++++++++++
> > 4 files changed, 418 insertions(+)
> > create mode 100644 lib/libfdt/fdt_overlay.c
> >
>
> Is there a change log?
Yes, in the cover letter.
> > +static int overlay_update_local_node_references(void *fdto,
> > + int tree_node,
> > + int fixup_node,
> > + uint32_t delta)
> > +{
>
> Please add function comments for all of these.
Ack
> > +static int overlay_update_local_references(void *dto, uint32_t delta)
> > +{
> > + int fixups;
> > +
> > + fixups = fdt_path_offset(dto, "/__local_fixups__");
> > + if (fixups < 0) {
> > + /*
> > + * There's no local phandles to adjust, bail out
>
> On on line:
>
> /* There's not local ... */
Ok.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160627/cdad4f28/attachment.sig>
next prev parent reply other threads:[~2016-06-27 7:13 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 14:27 [U-Boot] [PATCH v3 00/12] cmd: fdt: Add device tree overlays support Maxime Ripard
2016-06-24 14:27 ` [U-Boot] [PATCH v3 01/12] cmd: fdt: Narrow the check for fdt addr Maxime Ripard
2016-06-24 14:27 ` [U-Boot] [PATCH v3 02/12] scripts: Makefile.lib: Sanitize DTB names Maxime Ripard
2016-06-24 14:27 ` [U-Boot] [PATCH v3 03/12] vsprintf: Include stdarg for va_list Maxime Ripard
2016-06-24 14:27 ` [U-Boot] [PATCH v3 04/12] libfdt: Add new headers and defines Maxime Ripard
2016-06-26 2:53 ` Simon Glass
2016-06-26 15:39 ` David Gibson
2016-06-27 7:25 ` Maxime Ripard
2016-06-28 3:02 ` David Gibson
2016-06-24 14:27 ` [U-Boot] [PATCH v3 05/12] libfdt: Add iterator over properties Maxime Ripard
2016-06-26 2:53 ` Simon Glass
2016-06-24 14:27 ` [U-Boot] [PATCH v3 06/12] libfdt: Add max phandle retrieval function Maxime Ripard
2016-06-26 2:53 ` Simon Glass
2016-06-24 14:27 ` [U-Boot] [PATCH v3 07/12] libfdt: Add fdt_setprop_inplace_by_index Maxime Ripard
2016-06-26 2:53 ` Simon Glass
2016-06-26 8:09 ` Maxime Ripard
2016-06-26 15:45 ` David Gibson
2016-06-27 9:16 ` Maxime Ripard
2016-06-28 3:05 ` David Gibson
2016-06-24 14:27 ` [U-Boot] [PATCH v3 08/12] libfdt: Add fdt_path_offset_namelen Maxime Ripard
2016-06-26 2:53 ` Simon Glass
2016-06-26 8:10 ` Maxime Ripard
2016-06-29 3:27 ` Simon Glass
2016-06-26 15:47 ` David Gibson
2016-06-24 14:27 ` [U-Boot] [PATCH v3 09/12] libfdt: Add fdt_getprop_namelen_w Maxime Ripard
2016-06-26 2:53 ` Simon Glass
2016-06-26 8:11 ` Maxime Ripard
2016-06-26 15:49 ` David Gibson
2016-06-27 7:29 ` Maxime Ripard
2016-06-24 14:27 ` [U-Boot] [PATCH v3 10/12] libfdt: Add overlay application function Maxime Ripard
2016-06-26 2:53 ` Simon Glass
2016-06-27 7:13 ` Maxime Ripard [this message]
2016-06-27 5:26 ` David Gibson
2016-06-27 11:40 ` Maxime Ripard
2016-06-28 3:12 ` David Gibson
2016-06-30 2:34 ` Frank Rowand
2016-06-30 5:08 ` David Gibson
2016-06-24 14:27 ` [U-Boot] [PATCH v3 11/12] cmd: fdt: add fdt overlay application subcommand Maxime Ripard
2016-06-24 14:27 ` [U-Boot] [PATCH v3 12/12] tests: Introduce DT overlay tests Maxime Ripard
2016-06-27 5:26 ` David Gibson
2016-06-27 6:30 ` Maxime Ripard
2016-06-27 6:47 ` David Gibson
2016-06-26 15:37 ` [U-Boot] [PATCH v3 00/12] cmd: fdt: Add device tree overlays support David Gibson
2016-06-27 6:29 ` Maxime Ripard
2016-06-29 3:28 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627071316.GP4000@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox