From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v3, 3/6] autoboot: remove CONFIG_ZERO_BOOTDELAY_CHECK
Date: Fri, 1 Jul 2016 21:37:35 -0400 [thread overview]
Message-ID: <20160702013735.GS25693@bill-the-cat> (raw)
In-Reply-To: <1467012184-3231-4-git-send-email-yamada.masahiro@socionext.com>
On Mon, Jun 27, 2016 at 04:23:01PM +0900, Masahiro Yamada wrote:
> As the help message of CONFIG_BOOTDELAY says, CONFIG_BOOTDELAY=-2
> means the autoboot with no delay, with no abort check even if
> CONFIG_ZERO_BOOTDELAY_CHECK is defined.
>
> To sum up, the autoboot behaves as follows:
>
> [1] CONFIG_BOOTDELAY=0 && CONFIG_ZERO_BOOTDELAY_CHECK=y
> autoboot with no delay, but you can abort it by key input
>
> [2] CONFIG_BOOTDELAY=0 && CONFIG_ZERO_BOOTDELAY_CHECK=n
> autoboot with no delay, with no check for abort
>
> [3] CONFIG_BOOTDELAY=-1
> disable autoboot
>
> [4] CONFIG_BOOTDELAY=-2
> autoboot with no delay, with no check for abort
>
> As you notice, [2] and [4] come to the same result, which means we
> do not need CONFIG_ZERO_BOOTDELAY_CHECK. We can control all the
> cases only by CONFIG_BOOTDELAY, like this:
>
> [1] CONFIG_BOOTDELAY=0
> autoboot with no delay, but you can abort it by key input
>
> [2] CONFIG_BOOTDELAY=-1
> disable autoboot
>
> [3] CONFIG_BOOTDELAY=-2
> autoboot with no delay, with no check for abort
>
> This commit converts the logic as follow:
> CONFIG_BOOTDELAY=0 && CONFIG_ZERO_BOOTDELAY_CHECK=n
> --> CONFIG_BOOTDELAY=-2
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Reviewed-by: Stefan Roese <sr@denx.de>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Acked-by: Vladimir Zapolskiy <vz@mleia.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>
> Acked-by: Christian Riesch <christian.riesch@omicronenergy.com>
> Acked-by: Hannes Schmelzer <hannes.schmelzer@br-automation.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160701/89d7e10a/attachment.sig>
next prev parent reply other threads:[~2016-07-02 1:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 7:22 [U-Boot] [PATCH v3 0/6] autoboot cleanups Masahiro Yamada
2016-06-27 7:22 ` [U-Boot] [PATCH v3 1/6] ARM: socfpga: move CONFIG_BOOTDELAY to Kconfig for IS1 board Masahiro Yamada
2016-06-27 7:29 ` Stefan Roese
2016-07-02 1:37 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-27 7:23 ` [U-Boot] [PATCH v3 2/6] doc: bootdelay: drop explanation about CONFIG_BOOTDELAY from README Masahiro Yamada
2016-07-02 1:37 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-27 7:23 ` [U-Boot] [PATCH v3 3/6] autoboot: remove CONFIG_ZERO_BOOTDELAY_CHECK Masahiro Yamada
2016-07-02 1:37 ` Tom Rini [this message]
2016-06-27 7:23 ` [U-Boot] [PATCH v3 4/6] autoboot: rename abortboot_{keyed, normal} to __abortboot Masahiro Yamada
2016-07-02 1:37 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-27 7:23 ` [U-Boot] [PATCH v3 5/6] autoboot: move CONFIG_SILENT_CONSOLE handling Masahiro Yamada
2016-07-02 1:37 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-27 7:23 ` [U-Boot] [PATCH v3 6/6] autoboot: move bootdelay >= 0 check to abortboot() Masahiro Yamada
2016-07-02 1:37 ` [U-Boot] [U-Boot, v3, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160702013735.GS25693@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox