From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 8 Jul 2016 20:28:43 -0400 Subject: [U-Boot] [U-Boot,v2] SPL: tiny-printf: avoid any BSS usage In-Reply-To: References: <1467987515-2794-1-git-send-email-andre.przywara@arm.com> <20160708165041.GA6425@bill-the-cat> Message-ID: <20160709002843.GP25382@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Jul 08, 2016 at 11:48:12PM +0200, Marek Vasut wrote: > On 07/08/2016 06:50 PM, Tom Rini wrote: > >On Fri, Jul 08, 2016 at 03:18:35PM +0100, Andre Przywara wrote: > > > >>As printf calls may be executed quite early, we should avoid using any > >>BSS stored variables, since some boards put BSS in DRAM, which may not > >>have been initialised yet. > >>Explicitly mark those "static global" variables as belonging to the > >>.data section, to keep tiny-printf clear of any BSS usage. > >> > >>Signed-off-by: Andre Przywara > > > >Applied to u-boot/master, thanks! > > > Mind you, __section(".data") would be enough, no need to spell the > whole attribute. True, but that's a helper that's not really utilized today. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: