From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Date: Tue, 12 Jul 2016 15:10:17 +1000 Subject: [U-Boot] [PATCH v4 09/13] libfdt: Add fdt_getprop_namelen_w In-Reply-To: <20160711071227.GE4589@lukather> References: <20160705082646.25044-1-maxime.ripard@free-electrons.com> <20160705082646.25044-10-maxime.ripard@free-electrons.com> <20160706012248.GS2251@voom.fritz.box> <20160711071227.GE4589@lukather> Message-ID: <20160712051017.GV16355@voom.fritz.box> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jul 11, 2016 at 09:12:27AM +0200, Maxime Ripard wrote: > On Wed, Jul 06, 2016 at 11:22:48AM +1000, David Gibson wrote: > > On Tue, Jul 05, 2016 at 10:26:42AM +0200, Maxime Ripard wrote: > > > Add a function to retrieve a writeable property only by the first > > > characters of its name. > > > > > > Signed-off-by: Maxime Ripard > > > > This shouldn't be exported, so it should go into libfdt_internal.h. > > > > > --- > > > include/libfdt.h | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/include/libfdt.h b/include/libfdt.h > > > index f13b01f08f71..a55d2d0d8c7b 100644 > > > --- a/include/libfdt.h > > > +++ b/include/libfdt.h > > > @@ -619,6 +619,13 @@ const void *fdt_getprop_by_offset(const void *fdt, int offset, > > > */ > > > const void *fdt_getprop_namelen(const void *fdt, int nodeoffset, > > > const char *name, int namelen, int *lenp); > > > +static inline void *fdt_getprop_namelen_w(void *fdt, int nodeoffset, > > > + const char *name, int namelen, > > > + int *lenp) > > > +{ > > > + return (void *)(uintptr_t)fdt_getprop_namelen(fdt, nodeoffset, name, > > > + namelen, lenp); > > > > uintptr_t ?? > > This is defined in the exact same way than fdt_getprop_w. Should I > change that as well? Good point. I wonder why I did that in the first place. I suspect it was to stop sparse whinging about the removed const. It's ok for now, we can clean both up later if we get a better idea. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: