From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] COSMETIC: mmc: sdhci: Add CONFIG_ prefix to SDHCI_READ_STATUS_TIMEOUT
Date: Tue, 12 Jul 2016 14:24:11 +0200 [thread overview]
Message-ID: <20160712142411.11687dec@amdc2363> (raw)
In-Reply-To: <20160712121425.GB25382@bill-the-cat>
Hi Tom,
> On Mon, Jul 11, 2016 at 02:49:03PM +0200, Lukasz Majewski wrote:
>
> > This change gives common prefix for SDHCI_READ_STATUS_TIMEOUT.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
>
> Hang on, didn't we just intentionally not CONFIG_ this option and not
> add it to Kconfig?
Apparently, I was not aware of such intentions :-).
I do agree that we should add new options to Kconfig, so with second
thoughts I think that this patch was not so good idea...
> If we're making these tunable they need to be in
> Kconfig and if needed, non-asked questions, ie:
> int SDHCI_READ_STATUS_TIMEOUT
> default 100 if FOO_PLATFORM
> default 500 if BAR_PLATFORM
> default 1000
>
> Thanks!
>
BTW: I'm testing Jeahoon's patches for fixing this issue, so probably
this patch series could be dropped.
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
prev parent reply other threads:[~2016-07-12 12:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 12:49 [U-Boot] [PATCH 1/3] COSMETIC: mmc: sdhci: Add CONFIG_ prefix to SDHCI_READ_STATUS_TIMEOUT Lukasz Majewski
2016-07-11 12:49 ` [U-Boot] [PATCH 2/3] FIX: mmc: sdhci: Board specific definitions for SDHCI CMD and READ TIMEOUTS Lukasz Majewski
2016-07-12 12:03 ` Jaehoon Chung
2016-07-11 12:49 ` [U-Boot] [PATCH 3/3] FIX: mmc: sdhci: exynos4: Define smaller SDHCI timeouts for Exynos4 based boards Lukasz Majewski
2016-07-12 12:14 ` [U-Boot] [PATCH 1/3] COSMETIC: mmc: sdhci: Add CONFIG_ prefix to SDHCI_READ_STATUS_TIMEOUT Tom Rini
2016-07-12 12:24 ` Lukasz Majewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712142411.11687dec@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox