From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B
Date: Tue, 12 Jul 2016 14:55:39 +0200 [thread overview]
Message-ID: <20160712145539.354d5fbd@amdc2363> (raw)
In-Reply-To: <1468325927-13128-2-git-send-email-jh80.chung@samsung.com>
Hi Jaehoon,
> Unset the SDHCI_QUIRK_BROKEN_R1B for exynos SoC.
> (Tested on Exynos4 Boards.)
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/mmc/s5p_sdhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c
> index 44353c7..3bace21 100644
> --- a/drivers/mmc/s5p_sdhci.c
> +++ b/drivers/mmc/s5p_sdhci.c
> @@ -68,7 +68,7 @@ static int s5p_sdhci_core_init(struct sdhci_host
> *host) host->name = S5P_NAME;
>
> host->quirks = SDHCI_QUIRK_NO_HISPD_BIT |
> SDHCI_QUIRK_BROKEN_VOLTAGE |
> - SDHCI_QUIRK_BROKEN_R1B | SDHCI_QUIRK_32BIT_DMA_ADDR |
> + SDHCI_QUIRK_32BIT_DMA_ADDR |
> SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_USE_WIDE8;
> host->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 |
> MMC_VDD_165_195; host->version = sdhci_readw(host,
> SDHCI_HOST_VERSION);
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Tested-by: Lukasz Majewski <l.majewski@samsung.com>
Test HW: Odroid U3 (Exynos4):
Odroid # ext4load mmc 0:2 0x41000000 dat_31M.img
32505856 bytes read in 1471 ms (21.1 MiB/s)
Odroid # ext4write mmc 0:2 0x41000000 /dat_w55.img 0x1f00000
File System is consistent
update journal finished
32505856 bytes written in 3528 ms (8.8 MiB/s)
Performance improvement is even better than with previously proposed
patches.
Test HW: Odroid XU3 (Exynos5):
ODROID-XU3 # ext4load mmc 0:2 0x41000000 dat_31M.img
32505856 bytes read in 6309 ms (4.9 MiB/s)
ODROID-XU3 # ext4write mmc 0:2 0x41000000 /dat_w1.img 0x1f00000
File System is consistent
update journal finished
32505856 bytes written in 4884 ms (6.3 MiB/s)
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2016-07-12 12:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 12:18 [U-Boot] [PATCH 1/2] mmc: sdhci: set to INT_DATA_END when there are data Jaehoon Chung
2016-07-12 12:18 ` [U-Boot] [PATCH 2/2] mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B Jaehoon Chung
2016-07-12 12:55 ` Lukasz Majewski [this message]
2016-08-05 2:24 ` [U-Boot] [U-Boot, " Jaehoon Chung
2016-07-12 12:55 ` [U-Boot] [PATCH 1/2] mmc: sdhci: set to INT_DATA_END when there are data Lukasz Majewski
2016-07-25 4:55 ` Jaehoon Chung
2016-07-25 10:10 ` Minkyu Kang
2016-07-25 10:21 ` Lukasz Majewski
2016-07-25 23:23 ` Steve Rae
2016-07-25 23:28 ` Steve Rae
2016-07-26 9:13 ` Lukasz Majewski
2016-07-26 16:10 ` Steve Rae
2016-07-27 5:11 ` Jaehoon Chung
2016-08-01 10:05 ` Lukasz Majewski
2016-08-05 2:24 ` [U-Boot] [U-Boot, " Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712145539.354d5fbd@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox