From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Tue, 12 Jul 2016 14:55:39 +0200 Subject: [U-Boot] [PATCH 2/2] mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B In-Reply-To: <1468325927-13128-2-git-send-email-jh80.chung@samsung.com> References: <1468325927-13128-1-git-send-email-jh80.chung@samsung.com> <1468325927-13128-2-git-send-email-jh80.chung@samsung.com> Message-ID: <20160712145539.354d5fbd@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Jaehoon, > Unset the SDHCI_QUIRK_BROKEN_R1B for exynos SoC. > (Tested on Exynos4 Boards.) > > Signed-off-by: Jaehoon Chung > --- > drivers/mmc/s5p_sdhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c > index 44353c7..3bace21 100644 > --- a/drivers/mmc/s5p_sdhci.c > +++ b/drivers/mmc/s5p_sdhci.c > @@ -68,7 +68,7 @@ static int s5p_sdhci_core_init(struct sdhci_host > *host) host->name = S5P_NAME; > > host->quirks = SDHCI_QUIRK_NO_HISPD_BIT | > SDHCI_QUIRK_BROKEN_VOLTAGE | > - SDHCI_QUIRK_BROKEN_R1B | SDHCI_QUIRK_32BIT_DMA_ADDR | > + SDHCI_QUIRK_32BIT_DMA_ADDR | > SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_USE_WIDE8; > host->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | > MMC_VDD_165_195; host->version = sdhci_readw(host, > SDHCI_HOST_VERSION); Acked-by: Lukasz Majewski Tested-by: Lukasz Majewski Test HW: Odroid U3 (Exynos4): Odroid # ext4load mmc 0:2 0x41000000 dat_31M.img 32505856 bytes read in 1471 ms (21.1 MiB/s) Odroid # ext4write mmc 0:2 0x41000000 /dat_w55.img 0x1f00000 File System is consistent update journal finished 32505856 bytes written in 3528 ms (8.8 MiB/s) Performance improvement is even better than with previously proposed patches. Test HW: Odroid XU3 (Exynos5): ODROID-XU3 # ext4load mmc 0:2 0x41000000 dat_31M.img 32505856 bytes read in 6309 ms (4.9 MiB/s) ODROID-XU3 # ext4write mmc 0:2 0x41000000 /dat_w1.img 0x1f00000 File System is consistent update journal finished 32505856 bytes written in 4884 ms (6.3 MiB/s) -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group