From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: start.S: Fix startup of dragonboard410c
Date: Thu, 14 Jul 2016 17:33:50 -0400 [thread overview]
Message-ID: <20160714213350.GH7260@bill-the-cat> (raw)
In-Reply-To: <1cab9e50-da06-8b5d-419a-6881c94d3116@arm.com>
On Tue, Jul 12, 2016 at 11:10:28PM +0100, Andr? Przywara wrote:
> On 12/07/16 21:15, Mateusz Kulikowski wrote:
>
> Hi Mateusz,
>
> > Commit d73718f3 breaks devices where:
> > - There is EL2/EL3 firmware and
> > - U-Boot starts in NS EL1 and
> > - EL2/EL3 firmware didn't unlocked write-access to CPUECTLR_EL1.
> >
> > This patch makes that change opt-out configuration option,
> > and disables it for dragonboard410c.
>
> thanks for bringing this up!
> You are totally right, as this register isn't architecturally defined,
> we should never set it without checking for a particular core.
> Actually even that is not enough, as it's also access restricted - even
> defaulting to RO - as you mentioned.
>
> So I am very much for a board specific _opt-in_ solution, also as ARM
> Trusted Firmware takes care of the bit already, for instance.
>
> Mingkai Hu, can you say for which board/SoC/family the original patch
> was needed for? Layerscape?
OK, I'm going to revert the original patch here (and would recommend
that distros that are picking up v2016.07 do the same). Thanks all!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160714/03931d88/attachment.sig>
prev parent reply other threads:[~2016-07-14 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 20:15 [U-Boot] [PATCH] arm: start.S: Fix startup of dragonboard410c Mateusz Kulikowski
2016-07-12 22:10 ` André Przywara
2016-07-14 21:33 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714213350.GH7260@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox