From: Max Filippov <jcmvbkbc@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/8] xtensa: add core information for the dc232b processor
Date: Fri, 15 Jul 2016 02:15:46 +0300 [thread overview]
Message-ID: <20160714231546.GC31001@octofox.metropolis> (raw)
In-Reply-To: <CAPnjgZ0v4XeVi9D9km=r_0geMmdc1wCof+U24DyCKQEP4Y1L+g@mail.gmail.com>
Hi Simon,
On Tue, Jul 12, 2016 at 03:56:46PM -0600, Simon Glass wrote:
> On 8 July 2016 at 09:42, Max Filippov <jcmvbkbc@gmail.com> wrote:
> > From: Chris Zankel <chris@zankel.net>
>
> Commit message?
Ok, will add.
> >
> > Signed-off-by: Chris Zankel <chris@zankel.net>
> > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> > ---
> > arch/xtensa/include/asm/arch-dc232b/core.h | 422 ++++++++++++++++++++++++++
> > arch/xtensa/include/asm/arch-dc232b/tie-asm.h | 120 ++++++++
> > arch/xtensa/include/asm/arch-dc232b/tie.h | 129 ++++++++
> > 3 files changed, 671 insertions(+)
> > create mode 100644 arch/xtensa/include/asm/arch-dc232b/core.h
> > create mode 100644 arch/xtensa/include/asm/arch-dc232b/tie-asm.h
> > create mode 100644 arch/xtensa/include/asm/arch-dc232b/tie.h
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> nits below.
>
> >
> > diff --git a/arch/xtensa/include/asm/arch-dc232b/core.h b/arch/xtensa/include/asm/arch-dc232b/core.h
> > new file mode 100644
> > index 0000000..7fd1aee
> > --- /dev/null
> > +++ b/arch/xtensa/include/asm/arch-dc232b/core.h
> > @@ -0,0 +1,422 @@
> > +/*
> > + * Xtensa processor core configuration information.
> > + *
> > + * Copyright (c) 1999-2007 Tensilica Inc.
> > + *
> > + * SPDX-License-Identifier: GPL-2.0+
> > + */
> > +
> > +#ifndef _XTENSA_CORE_CONFIGURATION_H
> > +#define _XTENSA_CORE_CONFIGURATION_H
> > +
> > +
> > +/****************************************************************************
> > + Parameters Useful for Any Code, USER or PRIVILEGED
> > + ****************************************************************************/
> > +
> > +/*
> > + * Note: Macros of the form XCHAL_HAVE_*** have a value of 1 if the option is
> > + * configured, and a value of 0 otherwise. These macros are always defined.
> > + */
> > +
> > +
> > +/*----------------------------------------------------------------------
> > + ISA
> > + ----------------------------------------------------------------------*/
> > +
> > +#define XCHAL_HAVE_BE 0 /* big-endian byte ordering */
> > +#define XCHAL_HAVE_WINDOWED 1 /* windowed registers option */
> > +#define XCHAL_NUM_AREGS 32 /* num of physical addr regs */
> > +#define XCHAL_NUM_AREGS_LOG2 5 /* log2(XCHAL_NUM_AREGS) */
> > +#define XCHAL_MAX_INSTRUCTION_SIZE 3 /* max instr bytes (3..8) */
> > +#define XCHAL_HAVE_DEBUG 1 /* debug option */
> > +#define XCHAL_HAVE_DENSITY 1 /* 16-bit instructions */
> > +#define XCHAL_HAVE_LOOPS 1 /* zero-overhead loops */
> > +#define XCHAL_HAVE_NSA 1 /* NSA/NSAU instructions */
> > +#define XCHAL_HAVE_MINMAX 1 /* MIN/MAX instructions */
> > +#define XCHAL_HAVE_SEXT 1 /* SEXT instruction */
> > +#define XCHAL_HAVE_CLAMPS 1 /* CLAMPS instruction */
> > +#define XCHAL_HAVE_MUL16 1 /* MUL16S/MUL16U instructions */
> > +#define XCHAL_HAVE_MUL32 1 /* MULL instruction */
> > +#define XCHAL_HAVE_MUL32_HIGH 0 /* MULUH/MULSH instructions */
> > +#define XCHAL_HAVE_DIV32 1 /* QUOS/QUOU/REMS/REMU instructions */
> > +#define XCHAL_HAVE_L32R 1 /* L32R instruction */
> > +#define XCHAL_HAVE_ABSOLUTE_LITERALS 1 /* non-PC-rel (extended) L32R */
> > +#define XCHAL_HAVE_CONST16 0 /* CONST16 instruction */
> > +#define XCHAL_HAVE_ADDX 1 /* ADDX#/SUBX# instructions */
> > +#define XCHAL_HAVE_WIDE_BRANCHES 0 /* B*.W18 or B*.W15 instr's */
> > +#define XCHAL_HAVE_PREDICTED_BRANCHES 0 /* B[EQ/EQZ/NE/NEZ]T instr's */
> > +#define XCHAL_HAVE_CALL4AND12 1 /* (obsolete option) */
> > +#define XCHAL_HAVE_ABS 1 /* ABS instruction */
> > +/*#define XCHAL_HAVE_POPC 0*/ /* POPC instruction */
> > +/*#define XCHAL_HAVE_CRC 0*/ /* CRC instruction */
> > +#define XCHAL_HAVE_RELEASE_SYNC 1 /* L32AI/S32RI instructions */
> > +#define XCHAL_HAVE_S32C1I 1 /* S32C1I instruction */
> > +#define XCHAL_HAVE_SPECULATION 0 /* speculation */
> > +#define XCHAL_HAVE_FULL_RESET 1 /* all regs/state reset */
> > +#define XCHAL_NUM_CONTEXTS 1 /* */
> > +#define XCHAL_NUM_MISC_REGS 2 /* num of scratch regs (0..4) */
> > +#define XCHAL_HAVE_TAP_MASTER 0 /* JTAG TAP control instr's */
> > +#define XCHAL_HAVE_PRID 1 /* processor ID register */
> > +#define XCHAL_HAVE_THREADPTR 1 /* THREADPTR register */
> > +#define XCHAL_HAVE_BOOLEANS 0 /* boolean registers */
> > +#define XCHAL_HAVE_CP 1 /* CPENABLE reg (coprocessor) */
> > +#define XCHAL_CP_MAXCFG 8 /* max allowed cp id plus one */
> > +#define XCHAL_HAVE_MAC16 1 /* MAC16 package */
> > +#define XCHAL_HAVE_VECTORFPU2005 0 /* vector floating-point pkg */
> > +#define XCHAL_HAVE_FP 0 /* floating point pkg */
> > +#define XCHAL_HAVE_VECTRA1 0 /* Vectra I pkg */
> > +#define XCHAL_HAVE_VECTRALX 0 /* Vectra LX pkg */
> > +#define XCHAL_HAVE_HIFI2 0 /* HiFi2 Audio Engine pkg */
> > +
> > +
> > +/*----------------------------------------------------------------------
>
> Do we need all these lines and stars?
These files are autogenerated, so I tried to avoid editing them.
Sure I can remove these lines and start if absolutely necessary.
--
Thanks.
-- Max
next prev parent reply other threads:[~2016-07-14 23:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 15:41 [U-Boot] [PATCH v2 0/8] U-Boot port to Xtensa architecture Max Filippov
2016-07-08 15:41 ` [U-Boot] [PATCH 1/8] xtensa: add support for the xtensa processor architecture [1/2] Max Filippov
2016-07-12 21:56 ` Simon Glass
2016-07-14 21:55 ` Max Filippov
2016-07-08 15:42 ` [U-Boot] [PATCH 2/8] xtensa: add support for the xtensa processor architecture [2/2] Max Filippov
2016-07-12 21:56 ` Simon Glass
2016-07-14 22:58 ` Max Filippov
2016-07-15 0:20 ` Simon Glass
2016-07-08 15:42 ` [U-Boot] [PATCH 3/8] xtensa: add core information for the dc232b processor Max Filippov
2016-07-12 21:56 ` Simon Glass
2016-07-14 23:15 ` Max Filippov [this message]
2016-07-15 0:20 ` Simon Glass
2016-07-08 15:42 ` [U-Boot] [PATCH 4/8] xtensa: add core information for the dc233c processor Max Filippov
2016-07-12 21:56 ` Simon Glass
2016-07-14 23:19 ` Max Filippov
2016-07-08 15:42 ` [U-Boot] [PATCH 5/8] xtensa: add core information for the de212 processor Max Filippov
2016-07-12 21:56 ` Simon Glass
2016-07-14 23:20 ` Max Filippov
2016-07-08 15:42 ` [U-Boot] [PATCH 6/8] net/ethoc: support private memory configurations Max Filippov
2016-07-12 21:56 ` Simon Glass
2016-07-14 23:34 ` Max Filippov
2016-07-15 0:20 ` Simon Glass
2016-07-08 15:42 ` [U-Boot] [PATCH 7/8] net/ethoc: don't advertise gigabit on the connected PHY Max Filippov
2016-07-12 21:56 ` Simon Glass
2016-07-14 23:41 ` Max Filippov
2016-07-13 6:28 ` Michal Simek
2016-07-14 23:51 ` Max Filippov
2016-07-08 15:42 ` [U-Boot] [PATCH 8/8] xtensa: add support for the 'xtfpga' evaluation board Max Filippov
2016-07-12 21:57 ` Simon Glass
2016-07-15 0:13 ` Max Filippov
2016-07-13 6:35 ` Michal Simek
2016-07-15 0:04 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714231546.GC31001@octofox.metropolis \
--to=jcmvbkbc@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox