From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "Revert "rockchip: rk3288: correct sdram setting""
Date: Fri, 15 Jul 2016 12:16:27 -0400 [thread overview]
Message-ID: <20160715161627.GQ7260@bill-the-cat> (raw)
In-Reply-To: <20160715152457.17574-1-john@metanate.com>
On Fri, Jul 15, 2016 at 04:24:57PM +0100, John Keeping wrote:
> The original commit was correct, except fot the priority of the mask
> when extracting "bw" to calculate the SDRAM size. Add the necessary
> parentheses so that we can apply the original fix.
>
> This reverts commit b525556e6325aa71427c0519f36247981cd444df.
>
> Signed-off-by: John Keeping <john@metanate.com>
I don't like to revert a revert, it starts to get confusing to follow
the history. It sounds like this isn't an exact revert either, it's
reverting and then fixing the original commit. Please re-word the
message so that it's clear that we're re-implementing what b525556
reverted but fixing ... Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160715/7decb1a4/attachment.sig>
next prev parent reply other threads:[~2016-07-15 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 15:24 [U-Boot] [PATCH] Revert "Revert "rockchip: rk3288: correct sdram setting"" John Keeping
2016-07-15 16:16 ` Tom Rini [this message]
2016-07-15 16:33 ` [U-Boot] [PATCH v2] rockchip: sdram: Fix register layout for Linux John Keeping
2016-07-15 17:14 ` Tom Rini
2016-07-17 14:13 ` Simon Glass
2016-07-18 12:20 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715161627.GQ7260@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox