From: Scott Wood <oss@buserror.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] cmd, nand: add an option to disable the verification when writing in raw mode
Date: Sun, 24 Jul 2016 20:41:30 -0500 [thread overview]
Message-ID: <20160725014130.GA20982@home.buserror.net> (raw)
In-Reply-To: <1465980138-18496-1-git-send-email-boris.brezillon@free-electrons.com>
On Wed, Jun 15, 2016 at 10:42:18AM +0200, Boris Brezillon wrote:
> diff --git a/cmd/nand.c b/cmd/nand.c
> index 583a18f..3a5e3a0 100644
> --- a/cmd/nand.c
> +++ b/cmd/nand.c
> @@ -306,7 +306,7 @@ static void nand_print_and_set_info(int idx)
> }
>
> static int raw_access(struct mtd_info *mtd, ulong addr, loff_t off,
> - ulong count, int read)
> + ulong count, int read, int noverify)
> {
> int ret = 0;
>
> @@ -324,7 +324,7 @@ static int raw_access(struct mtd_info *mtd, ulong addr, loff_t off,
> ret = mtd_read_oob(mtd, off, &ops);
> } else {
> ret = mtd_write_oob(mtd, off, &ops);
> - if (!ret)
> + if (!ret && !no_verify)
> ret = nand_verify_page_oob(mtd, &ops, off);
"noverify" versus "no_verify"... I've fixed it while applying.
I assume/hope that you just sent an old version by mistake, and that this
was actually tested?
-Scott
next prev parent reply other threads:[~2016-07-25 1:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 8:42 [U-Boot] [PATCH] cmd, nand: add an option to disable the verification when writing in raw mode Boris Brezillon
2016-06-24 23:26 ` Tom Rini
2016-07-25 1:41 ` Scott Wood [this message]
2016-07-25 9:18 ` [U-Boot] " Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725014130.GA20982@home.buserror.net \
--to=oss@buserror.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox