From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Date: Mon, 25 Jul 2016 11:18:28 +0200 Subject: [U-Boot] cmd, nand: add an option to disable the verification when writing in raw mode In-Reply-To: <20160725014130.GA20982@home.buserror.net> References: <1465980138-18496-1-git-send-email-boris.brezillon@free-electrons.com> <20160725014130.GA20982@home.buserror.net> Message-ID: <20160725111828.55c2b14c@bbrezillon> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 24 Jul 2016 20:41:30 -0500 Scott Wood wrote: > On Wed, Jun 15, 2016 at 10:42:18AM +0200, Boris Brezillon wrote: > > diff --git a/cmd/nand.c b/cmd/nand.c > > index 583a18f..3a5e3a0 100644 > > --- a/cmd/nand.c > > +++ b/cmd/nand.c > > @@ -306,7 +306,7 @@ static void nand_print_and_set_info(int idx) > > } > > > > static int raw_access(struct mtd_info *mtd, ulong addr, loff_t off, > > - ulong count, int read) > > + ulong count, int read, int noverify) > > { > > int ret = 0; > > > > @@ -324,7 +324,7 @@ static int raw_access(struct mtd_info *mtd, ulong addr, loff_t off, > > ret = mtd_read_oob(mtd, off, &ops); > > } else { > > ret = mtd_write_oob(mtd, off, &ops); > > - if (!ret) > > + if (!ret && !no_verify) > > ret = nand_verify_page_oob(mtd, &ops, off); > > "noverify" versus "no_verify"... I've fixed it while applying. Oops, sorry about that. > > I assume/hope that you just sent an old version by mistake, and that this > was actually tested? Yes, it was tested, just forgot to amend my commit :-(. Thanks for fixing the problem. Regards, Boris