From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 25 Jul 2016 22:31:40 -0400 Subject: [U-Boot] [U-Boot, v2, 2/2] rsa: Fix return value and masked error In-Reply-To: <20160722065841.18093-3-mario.six@gdsys.cc> References: <20160722065841.18093-3-mario.six@gdsys.cc> Message-ID: <20160726023140.GA14698@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Jul 22, 2016 at 08:58:41AM +0200, mario.six at gdsys.cc wrote: > When signing images, we repeatedly call fit_add_file_data() with > successively increasing size values to include the keys in the DTB. > > Unfortunately, if large keys are used (such as 4096 bit RSA keys), this > process fails sometimes, and mkimage needs to be called repeatedly to > integrate the keys into the DTB. > > This is because fit_add_file_data actually returns the wrong error > code, and the loop terminates prematurely, instead of trying again with > a larger size value. > > This patch corrects the return value by fixing the return value of > fdt_add_bignum, fixes a case where an error is masked by a unconditional > setting of a return value variable, and also removes a error message, > which is misleading, since we actually allow the function to fail. A > (hopefully helpful) comment is also added to explain the lack of error > message. > > This is probably related to 1152a05 ("tools: Correct error handling in > fit_image_process_hash()") and the corresponding error reported here: > > https://www.mail-archive.com/u-boot at lists.denx.de/msg217417.html > > Signed-off-by: Mario Six > Reviewed-by: Simon Glass The delta between v1 and v2 has been applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: