From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 26 Jul 2016 08:13:37 -0400 Subject: [U-Boot] [PATCH 3/4] net: cpsw: Add support to drive gpios for ethernet to be functional In-Reply-To: References: <20160725131023.30656-1-vigneshr@ti.com> <20160725131023.30656-4-vigneshr@ti.com> <20160725133846.GJ14698@bill-the-cat> Message-ID: <20160726121337.GS14698@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jul 26, 2016 at 12:07:26PM +0530, R, Vignesh wrote: > > > On 7/25/2016 7:08 PM, Tom Rini wrote: > > On Mon, Jul 25, 2016 at 06:40:22PM +0530, Vignesh R wrote: > > > >> On DRA72 EVM, cpsw slaves may be muxed with other modules. This > >> selection is controlled by a pcf gpio line. Add support for cpsw driver > >> to acquire mode-gpios and select the appropriate slave using gpio APIs. > >> > >> Signed-off-by: Vignesh R > > > > Reviewed-by: Tom Rini > > > > Minor nit below: > > > >> @@ -1203,6 +1206,16 @@ static int cpsw_eth_ofdata_to_platdata(struct udevice *dev) > >> return -ENOENT; > >> } > >> > >> + > >> + num_mode_gpios = gpio_get_list_count(dev, "mode-gpios"); > > > > Extra blank line added. > > I added blank line for readability. So, that code block handling > toggling of "mode-gpios" is separated from the rest. I can remove that > if that seems unnecessary. Two empty lines in a row just isn't done so yes please, thanks. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: