[U-Boot] [PATCH 3/4] net: cpsw: Add support to drive gpios for ethernet to be functional

Vignesh R
2016-07-27T12:53:32Z

On Tuesday 26 July 2016 05:43 PM, Tom Rini wrote:
> On Tue, Jul 26, 2016 at 12:07:26PM +0530, R, Vignesh wrote:
>>
>>
>> On 7/25/2016 7:08 PM, Tom Rini wrote:
>>> On Mon, Jul 25, 2016 at 06:40:22PM +0530, Vignesh R wrote:
>>>
>>>> On DRA72 EVM, cpsw slaves may be muxed with other modules. This
>>>> selection is controlled by a pcf gpio line. Add support for cpsw driver
>>>> to acquire mode-gpios and select the appropriate slave using gpio APIs.
>>>>
>>>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>>>
>>> Reviewed-by: Tom Rini <trini@konsulko.com>
>>>
>>> Minor nit below:
>>>
>>>> @@ -1203,6 +1206,16 @@ static int cpsw_eth_ofdata_to_platdata(struct udevice *dev)
>>>> return -ENOENT;
>>>> }
>>>>
>>>> +
>>>> + num_mode_gpios = gpio_get_list_count(dev, "mode-gpios");
>>>
>>> Extra blank line added.
>>
>> I added blank line for readability. So, that code block handling
>> toggling of "mode-gpios" is separated from the rest. I can remove that
>> if that seems unnecessary.
>
> Two empty lines in a row just isn't done so yes please, thanks.

Sorry, I overlooked two empty lines. Will fix this in v2. Thanks for
the review.

--
Regards
Vignesh