From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 26 Jul 2016 09:04:16 -0400 Subject: [U-Boot] [PATCH] usb: dwc3: fixes crash in dwc3 driver due to types size mismatch In-Reply-To: <6C6B28D4DC342643927BEAFCE8707BF6762A8570@DBDE04.ent.ti.com> References: <1469097666-2758-1-git-send-email-ravibabu@ti.com> <23f5352b-213a-05fa-66b0-4c3d78073824@denx.de> <6C6B28D4DC342643927BEAFCE8707BF67629D4A6@DBDE04.ent.ti.com> <20160722115511.GL1623@bill-the-cat> <6C6B28D4DC342643927BEAFCE8707BF6762A8570@DBDE04.ent.ti.com> Message-ID: <20160726130416.GT14698@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jul 26, 2016 at 12:59:14PM +0000, B, Ravi wrote: > Tom > > >> based on phys_addr_t, so it triggered > >> the problem for DWC3, which had already potentially existed. > >> > >> > >> CONFIGs in Kconfig are guaranteed to be defined for all files, but > >> CONFIGs in board headers are not. > >> > >> So we need to make sure to add > >> #include (or #include ) in each source file. > >> > >> > >> So, your patch is doing a right thing. > >> > >> I will issue my Reviewed-by when you update the git-log. > >> > >> > >> (Moving CONFIG_PHYS_64BIT is a right thing as well) > > >Can we move PHYS_64BIT to Kconfig instead here please? This is the kind of thing we should be able to select based on SoC / board. Thanks! > > Yes, moving to PHYS_64BIT to Kconfig would be ideal fix. Thanks for pointing out. > > I have posted patch. > Commit: bac9e0: Kconfig: dra7x: Kconfig based PHYS_64BIT select based on Soc type You missed that Masahiro posted one as well that converted all targets :( Can you please grab his and confirm that it fixes the problem as well? Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: