From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 27 Jul 2016 23:28:45 -0400 Subject: [U-Boot] [PATCH v2 08/11] buildman: Avoid overwriting existing toolchain entries In-Reply-To: <1469673188-15834-9-git-send-email-sjg@chromium.org> References: <1469673188-15834-1-git-send-email-sjg@chromium.org> <1469673188-15834-9-git-send-email-sjg@chromium.org> Message-ID: <20160728032845.GD5926@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jul 27, 2016 at 08:33:05PM -0600, Simon Glass wrote: > The current code for setting up the toolchain config always writes the new > paths to an item called 'toolchain'. This means that it will overwrite any > existing toolchain item with the same name. In practice, this means that: > > buildman --fetch-arch all > > will fetch all toolchains, but only the path of the final one will be added > to the config. This normally works out OK, since most toolchains are the > same version (e.g. gcc 4.9) and will be found on the same path. But it is > not correct and toolchains for archs which don't use the same version will > not function as expected. > > Adjust the code to use a complete glob of the toolchain path. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: