From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 28 Jul 2016 09:22:44 -0400 Subject: [U-Boot] [RFC PATCH v2 1/5] spl: dfu: add dfu support in SPL In-Reply-To: References: <1469112797-5147-1-git-send-email-ravibabu@ti.com> <1469112797-5147-2-git-send-email-ravibabu@ti.com> <20160722134142.GB14698@bill-the-cat> <6C6B28D4DC342643927BEAFCE8707BF6762AB8A1@DBDE04.ent.ti.com> <20160727152520.GB22973@bill-the-cat> Message-ID: <20160728132244.GI5926@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Jul 28, 2016 at 04:09:10AM +0000, B, Ravi wrote: > Tom > > > On 27-Jul-2016, at 8:55 PM, Tom Rini wrote: > > > >> On Wed, Jul 27, 2016 at 02:04:24PM +0000, B, Ravi wrote: [snip] > >>>> diff --git a/common/command.c b/common/command.c index > >>>> e5d9b9c..d1c049c 100644 > >>>> --- a/common/command.c > >>>> +++ b/common/command.c > >>>> @@ -520,7 +520,7 @@ enum command_ret_t cmd_process(int flag, int argc, char * const argv[], > >>>> if (argc > cmdtp->maxargs) > >>>> rc = CMD_RET_USAGE; > >>>> > >>>> -#if defined(CONFIG_CMD_BOOTD) > >>>> +#if defined(CONFIG_CMD_BOOTD) && !defined(CONFIG_SPL_BUILD) > >>>> /* avoid "bootd" recursion */ Check whether they use DMA or PIO mode. > >> > >>>> else if (cmdtp->cmd == do_bootd) { > >>>> if (flag & CMD_FLAG_BOOTD) { > >> > >>> Why do we need this? > >> > >> Actually CONFIG_CMD_BOOTD is not required for SPL-DFU. > >> But cmd/Kconfg has defined CONFIG_CMD_BOOTD by default, which is causing compilation error for "do_bootd" not defined. > >> Again do_bootd depends on CONFIG_CMD_BOOTM which is not defined for SPL. > >> > >> What is best way? What do you suggest ? > > > > First, what is the exact compile error you get? And second, probably > > disable CMD_BOOTD. > > Since CMD_BOOTD is enabled, the function do_bood is undefined due to cmd/bootm.c compiled out for SPL. > > As you said, better to disable CMD_BOOTD. Ah, the problems of bringing in command parsing stuff to SPL. Yeah, for now lets turn off CMD_BOOTD but I think long term this is why we need to not be relying on command parsing but instead use the API directly. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: