From: Benjamin Tietz <benjamin@micronet24.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock
Date: Thu, 28 Jul 2016 21:28:09 +0200 [thread overview]
Message-ID: <20160728192809.GC2991@micronet24.de> (raw)
In-Reply-To: <CAPnjgZ1nDckHfwy4wgN6u1JoqA_gxZOY=mnLGs_3Guf6ZQ3O1w@mail.gmail.com>
Hello Vikas, hello Simon,
the new clk-API leaves me with a problem. Previously there was a
seperate way to access the clock-device itself (using clk_[gs]et_rate) and
the peripherals connected (clk_[gs]et_periph_rate). The former case now isn't
available no more. But the system clock in STM32 doesn't have a separate ID.
According to the device-tree the kernel doesn't care about that - or
uses special logic.
Possible solutions:
a) Using a magic ID. Unfortunately, the peripheral used in the current
device-tree are 0-based (and 0 is already in use), so this number isn't
available. Moving the IDs around would break compatibility to the linux
kernel.
Negative numbers look like errors.
Using a special high number looks unintuitive. And often result in
additional work-arounds in the future.
b) moving the sysclock and PLL-stuff in a seperate driver. That driver
should be found in the device-tree, too.
The device-tree should represent the hardware. Because of that, the
source-clock of the STM32 RCC device (the clocking subsystem), should
be either the external quartz or one of the internal sources, not a
pll-device. Apart from that, the kernel in its current configuration
probably is using this information to compute is current clock-speed.
c) extending the struct clk, which looks clumsy, too.
Any ideas?
regards
Benjamin
next prev parent reply other threads:[~2016-07-28 19:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 18:26 [U-Boot] [PATCH 2 00/22] DM: Cmd: GPIO/LED/STM32/CLK: provide command-line support for device-tree configured gpios and leds Benjamin Tietz
2016-06-20 18:26 ` [U-Boot] [PATCH v2 01/22] stm32: gpio: fix otype access Benjamin Tietz
2016-06-20 18:26 ` [U-Boot] [PATCH v2 02/22] stm32: gpio_direction_output: make sure, output is set to push-pull Benjamin Tietz
2016-06-20 18:26 ` [U-Boot] [PATCH v2 03/22] stm32: gpio_get_value: always return 0 or 1 Benjamin Tietz
2016-06-20 18:26 ` [U-Boot] [PATCH v2 04/22] stm32f429-discovery: config: enable status leds Benjamin Tietz
2016-06-20 18:26 ` [U-Boot] [PATCH v2 05/22] Cmd: led: provide a selector in kconfig Benjamin Tietz
2016-06-20 18:26 ` [U-Boot] [PATCH v2 06/22] DTS: stm32f429: provide device-tree files (from linux kernel) Benjamin Tietz
2016-06-20 18:26 ` [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock Benjamin Tietz
2016-07-12 16:02 ` Simon Glass
2016-07-12 16:08 ` Stephen Warren
2016-07-28 16:50 ` Benjamin Tietz
2016-07-28 19:28 ` Benjamin Tietz [this message]
2016-07-29 5:22 ` Benjamin Tietz
2016-07-29 16:04 ` Stephen Warren
2016-07-29 17:26 ` Benjamin Tietz
2016-07-29 18:02 ` Stephen Warren
2016-07-29 18:34 ` Benjamin Tietz
2016-08-01 1:03 ` Simon Glass
2016-06-20 18:26 ` [U-Boot] [PATCH v2 08/22] STM32: clock: provide dts-accessible clock driver Benjamin Tietz
2016-06-20 18:26 ` [U-Boot] [PATCH v2 09/22] DTS: STM32f429: add gpio-banks Benjamin Tietz
2016-06-20 18:26 ` [U-Boot] [PATCH v2 10/22] STM32: gpio: group SOC-specific code to one ifdef/elif construct Benjamin Tietz
2016-06-20 18:26 ` [U-Boot] [PATCH v2 11/22] GPIO: STM32: make DTS-aware Benjamin Tietz
2016-06-20 18:27 ` [U-Boot] [PATCH v2 12/22] STM32F429-discovery: led: disable board-specific code, if DM is selected Benjamin Tietz
2016-06-20 18:27 ` [U-Boot] [PATCH v2 13/22] GPIO/LED: make more robust, if STATUS_LED isn't selected Benjamin Tietz
2016-06-20 18:27 ` [U-Boot] [PATCH v2 14/22] Cmd: LED: rewrite to prepare non-static access Benjamin Tietz
2016-06-20 18:27 ` [U-Boot] [PATCH v2 15/22] DTS: STM32F429-disco: add board leds and enable rcc Benjamin Tietz
2016-06-20 18:27 ` [U-Boot] [PATCH v2 16/22] LED: add function to retrieve a device's label Benjamin Tietz
2016-06-20 18:27 ` [U-Boot] [PATCH v2 17/22] LED: provide function to count and get all (DM-)LEDs Benjamin Tietz
2016-06-20 18:27 ` [U-Boot] [PATCH v2 18/22] cmd: LED: be aware of DTS-configured leds Benjamin Tietz
2016-06-20 18:27 ` [U-Boot] [PATCH v2 19/22] LED: provide functionality to get led status Benjamin Tietz
2016-06-20 18:27 ` [U-Boot] [PATCH v2 20/22] LED: GPIO: provide get_on() op Benjamin Tietz
2016-06-20 18:27 ` [U-Boot] [PATCH v2 21/22] LED: provide toggling interface Benjamin Tietz
2016-06-20 18:27 ` [U-Boot] [PATCH v2 22/22] Cmd: LED: make DM-leds toggle Benjamin Tietz
2016-07-01 23:35 ` [U-Boot] [PATCH 2 00/22] DM: Cmd: GPIO/LED/STM32/CLK: provide command-line support for device-tree configured gpios and leds Vikas MANOCHA
2016-07-20 22:32 ` Vikas MANOCHA
2016-07-28 16:30 ` Benjamin Tietz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728192809.GC2991@micronet24.de \
--to=benjamin@micronet24.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox