From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/3] Some Kconfig move/fixups
Date: Sun, 31 Jul 2016 13:21:35 -0400 [thread overview]
Message-ID: <20160731172135.GF17970@bill-the-cat> (raw)
In-Reply-To: <CAK7LNAQEvvCaUTFUfGyxGouXC0RUNFtsUXdGreas2fJxJxTJiA@mail.gmail.com>
On Mon, Aug 01, 2016 at 01:24:21AM +0900, Masahiro Yamada wrote:
> Hi Tom,
>
>
> 2016-07-25 23:55 GMT+09:00 Tom Rini <trini@konsulko.com>:
> > On Mon, Jul 25, 2016 at 10:06:05PM +0900, Masahiro Yamada wrote:
> >
> >>
> >> Masahiro Yamada (3):
> >> cmd: bootz: make CMD_BOOTZ depend on CMD_BOOTM
> >> cmd: booti: move CONFIG_CMD_BOOTI to Kconfig
> >
> > After a quick skim of the code, I think we could split bootz/booti into
> > cmd/boot[zi].c and this I think might have been why I didn't make sure
> > that CMD_BOOT[ZI] depended on CMD_BOOTM in the first place. Can you
> > re-work them that way? Thanks!
> >
>
> bootz and boom are implemented
> heavily depending on bootm infrastructure,
> which is enabled by CONFIG_CMD_BOOTM.
>
> ./arch/mips/lib/Makefile:11:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/sparc/lib/Makefile:9:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/powerpc/lib/Makefile:32:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/openrisc/lib/Makefile:8:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/arm/lib/Makefile:29:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/arm/lib/Makefile:30:obj-$(CONFIG_CMD_BOOTM) += zimage.o
> ./arch/nios2/lib/Makefile:9:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/m68k/lib/Makefile:12:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/nds32/lib/Makefile:13:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/microblaze/lib/Makefile:8:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/sh/lib/Makefile:9:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/sandbox/lib/Makefile:14:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/x86/lib/Makefile:11:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/avr32/lib/Makefile:11:obj-$(CONFIG_CMD_BOOTM) += bootm.o
> ./arch/arc/lib/Makefile:26:obj-$(CONFIG_CMD_BOOTM) += bootm.o
Right, and in the cases where bootz/booti makes sense we should also add
in:
obj-$(CONFIG_CMD_BOOTZ) += bootm.o
and a comment about common infrastructure.
> ./cmd/Makefile:11:obj-$(CONFIG_CMD_BOOTM) += bootm.o
Right, and this gets split into 3 files.
> ./common/Makefile:28:obj-$(CONFIG_CMD_BOOTM) += bootm.o bootm_os.o
And we include these also for CONFIG_CMD_BOOTZ / CMD_BOOTI. Duplicates
are OK, they get sorted, I would swear..
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160731/2a4bc077/attachment.sig>
next prev parent reply other threads:[~2016-07-31 17:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 13:06 [U-Boot] [PATCH 0/3] Some Kconfig move/fixups Masahiro Yamada
2016-07-25 13:06 ` [U-Boot] [PATCH 1/3] cmd: bootz: make CMD_BOOTZ depend on CMD_BOOTM Masahiro Yamada
2016-07-25 13:17 ` Robert P. J. Day
2016-07-26 4:15 ` Masahiro Yamada
2016-07-25 13:06 ` [U-Boot] [PATCH 2/3] cmd: booti: move CONFIG_CMD_BOOTI to Kconfig Masahiro Yamada
2016-07-25 13:42 ` Michal Simek
2016-07-25 14:15 ` Ryan Harkin
2016-07-31 16:27 ` Masahiro Yamada
2016-07-31 17:23 ` Tom Rini
2016-07-25 13:06 ` [U-Boot] [PATCH 3/3] arm64: thunderx_88xx_defconfig: remove unneeded CONFIG_SYS_EXTRA_OPTIONS Masahiro Yamada
2016-07-25 14:56 ` Tom Rini
2016-07-26 2:33 ` [U-Boot] [U-Boot, " Tom Rini
2016-07-25 14:55 ` [U-Boot] [PATCH 0/3] Some Kconfig move/fixups Tom Rini
2016-07-31 16:24 ` Masahiro Yamada
2016-07-31 17:21 ` Tom Rini [this message]
2016-08-01 2:26 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160731172135.GF17970@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox