From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alban Bedel Date: Wed, 3 Aug 2016 11:46:25 +0200 Subject: [U-Boot] [PATCH] net: asix: Fix ASIX 88772B with driver model In-Reply-To: References: <20160803053254.7077-1-alban.bedel@avionic-design.de> Message-ID: <20160803114625.5bbc742d@avionic-0020> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 3 Aug 2016 09:00:42 +0200 Marek Vasut wrote: > On 08/03/2016 07:32 AM, Alban Bedel wrote: > > Commit 147271209a9d ("net: asix: fix operation without eeprom") > > added a special handling for ASIX 88772B that enable another > > type of header. This break the driver in DM mode as the extra handling > > needed in the receive path is missing. > > So add the extra handling ? I can do that too, but I though u-boot preferred to avoid useless code. > > However this new header mode is not required and only seems to > > increase the code complexity, so this patch revert this part of > > commit 147271209a9d. > > Why is it not required ? It works fine without, since 2012. In fact this change is not even mentioned in the log of commit 147271209a9d, so I really don't know why it was added in the first place. As can be seen in the revert all it does is adding 2 bytes to the USB packets that are then just skipped. Seems pretty useless to me. Alban -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: