From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alban Bedel Date: Thu, 4 Aug 2016 11:05:00 +0200 Subject: [U-Boot] [PATCH] tegra: config: Add 'pci enum' to preboot when PCI is enabled In-Reply-To: References: <20160803093558.15388-1-alban.bedel@avionic-design.de> <34267bde-a82c-22b7-760b-0d2b139543e6@wwwdotorg.org> Message-ID: <20160804110500.4734057c@avionic-0020> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 3 Aug 2016 19:16:57 -0600 Simon Glass wrote: > Hi, > > On 3 August 2016 at 09:37, Stephen Warren wrote: > > On 08/03/2016 03:35 AM, Alban Bedel wrote: > >> > >> For simplicity and backward compatibility automatically run 'pci enum' > >> via preboot when PCI is enabled. As preboot is already used for the > >> USB keyboard support this rework how CONFIG_PREBOOT is set to allow > >> combining several commands. > > > > > > For better or worse, this was a deliberate change, so I don't think this > > patch will be accepted. > > > > If it is, then you should apply it to all boards, not just Tegra boards, and > > adjust include/config_distro_bootcmd.h since it will no longer need to run > > "pci enum", and also test/py/tests/test_net.py won't need to either. > > The boards which need PCI to boot are still few... we've talked about > this before. It would be great if we could find a way to detect or be > told that boot devices are on PCI and probe it accordingly. Perhaps we > should have a driver flag? In my case I needed this for network boot. However I just found out that with a properly reseted environment this is already handled, so this is not needed. Sorry for the noise. Alban -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: