From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd: net: flush cache cacheline aligned
Date: Thu, 4 Aug 2016 13:46:56 -0400 [thread overview]
Message-ID: <20160804174656.GJ9942@bill-the-cat> (raw)
In-Reply-To: <2a0a0850bbdff7bfc83589686fc4af2e@agner.ch>
On Wed, Aug 03, 2016 at 07:43:24PM -0700, Stefan Agner wrote:
> On 2016-08-03 16:18, Joe Hershberger wrote:
> > On Tue, Aug 2, 2016 at 2:20 AM, Stefan Agner <stefan@agner.ch> wrote:
> >> From: Stefan Agner <stefan.agner@toradex.com>
> >>
> >> Flush loaded data cacheline aligned. This avoids warnings such as
> >> CACHE: Misaligned operation at range [81000000, 816d0fa8]
> >>
> >> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> >> ---
> >
> > This was already rejected once.
> > http://lists.denx.de/pipermail/u-boot/2012-April/121564.html
>
> Oh I see, and in the end the message was converted to a debug() call, in
> essence turning the whole problem back under a stone... :-)
>
> FWIW, I largely support Mike Frysinger's position in that discussion,
> and think it should be fine to flush these extra bytes...
I re-read most of that thread last-night and yes, it seems like rather
than solving the problem we just put it into a debug(). But if I
followed Mike's point right, we shouldn't be having a debug there
either, the flushes are fine? And as to Marek's point there about
driver bugs, it's perhaps only sub-optimal rather than a broken thing?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160804/d8641a35/attachment.sig>
next prev parent reply other threads:[~2016-08-04 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 7:20 [U-Boot] [PATCH] cmd: net: flush cache cacheline aligned Stefan Agner
2016-08-03 20:56 ` Fabio Estevam
2016-08-03 22:00 ` Simon Glass
2016-08-03 23:18 ` Joe Hershberger
2016-08-04 1:17 ` Simon Glass
2016-08-04 16:14 ` Joe Hershberger
2016-08-04 17:05 ` Stefan Agner
2016-08-04 2:43 ` Stefan Agner
2016-08-04 17:46 ` Tom Rini [this message]
2016-08-07 17:31 ` Stefan Agner
2016-08-14 20:06 ` [U-Boot] " Tom Rini
2016-08-15 4:40 ` Stefan Agner
2016-08-15 15:57 ` Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804174656.GJ9942@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox