[U-Boot] [GIT] Pull request: u-boot-dfu

B, Ravi
2016-08-17T07:40:04Z

Hi Heiko

>>>
>>> is that for master or next ?

>>This patch _was_ supposed to go to "master"

>>> Was this build tested ?

>>Unfortunately, not so thoroughly as I thought.

>>Moving dfu code to SPL causes following error on some boards:

>> arm: + smartweb
>>+In file included from ../include/dfu.h:18:0,
>>+ from ../common/dfu.c:16:
>>+../include/linux/usb/composite.h:331:9: error: requested alignment is
>>+not an integer constant
>>+ struct usb_device_descriptor __aligned(CONFIG_SYS_CACHELINE_SIZE) desc;
>>+ ^
>>+make[3]: *** [spl/common/dfu.o] Error 1
>>+make[2]: *** [spl/common] Error 2
>+make[1]: *** [spl/u-boot-spl] Error 2
>>+make: *** [sub-make] Error 2

The CONFIG_SYS_CACHELINE_SIZE is not defined for smartweb platform which is causing build error.
By defining this error goes away. What would be value for cache line size for smartweb platform? (32/64/..?)

>>Ravi, to reproduce you need to fetch u-boot-dfu/test

>>and run buildman:

>>This is only a small subset of affected boards, so please test also "arm" (which might take long time).

>>./tools/buildman/buildman.py --branch=HEAD siemens --detail --verbose
>>--show_errors --force-build --count=5 --output-dir=./BUILD/

>>Thanks Marek, for pointing out.

>I have test build for all ti-platforms, not checked for rest. My bad ..!
>I could reproduce this error, for some platform CONFIG_SYS_CACHELINE_SIZE is not defined. (eg. configs/smartweb_defconfig).
>I will check with "arm" as well, let you know.

Regards
Ravi