[U-Boot] [PATCH 02/13] spl: Kconfig: Add SPL__BOOT as Kconfig option

Simon Glass
2016-08-22T12:55:43Z

Hi Tom,

On 22 August 2016 at 06:25, Tom Rini <trini@konsulko.com> wrote:
> On Mon, Aug 22, 2016 at 09:53:18AM +0530, Lokesh Vutla wrote:
>>
>>
>> On Friday 19 August 2016 08:59 PM, Andrew F. Davis wrote:
>> > On 08/18/2016 11:10 PM, Lokesh Vutla wrote:
>> >>
>> >>
>> >> On Thursday 18 August 2016 09:11 PM, Andrew F. Davis wrote:
>> >>> Currently U-Boot proper has Kconfig options that enable the generation
>> >>> of U-Boot binaries that are capable of being booted from the selected
>> >>> boot media type. The same set of generation targets for SPL are assumed
>> >>> with various methods and config header hackery. On some platforms the
>> >>> options for SPL, such as load address, are dependent on boot type
>> >>> and cannot depend on boot image type selected for U-Boot proper.
>> >>> Add a Kconfig menu to select SPL boot image types, and populate it
>> >>> with the same media types as are already available for U-Boot proper.
>> >>> Uses of this option are added later.
>> >>>
>> >>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> >>> ---
>> >>> common/Kconfig | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> >>> 1 file changed, 69 insertions(+)
>> >>>
>> >>> diff --git a/common/Kconfig b/common/Kconfig
>> >>> index f594db5..90ba5b2 100644
>> >>> --- a/common/Kconfig
>> >>> +++ b/common/Kconfig
>> >>> @@ -156,6 +156,75 @@ config SPI_BOOT
>> >>> booted via SPI flash. This is not a must, some SoCs need this,
>> >>> somes not.
>> >>>
>> >>> +menu "SPL Boot media"
>> >>> + depends on SPL
>> >>> +
>> >>> +config SPL_NOR_BOOT
>> >>> + bool "Support for booting SPL from NOR flash"
>> >>> + default n
>> >>
>> >> Shouldn't this depend on SPL_NOR_SUPPORT? Similarly others.
>> >>
>> >
>> > Nope, these simply enable the SPL to be built for being itself loaded
>> > from this media, for instance the SPL does not need to know how to load
>> > images over UART just because it itself was.
>>
>> Right, but how does SPL decide the boot media to load images?. Typically
>> it tries to load from the same boot media it was loaded. If it couldn't
>> find then it will fallback to other options. At least it is good to
>> select SPL_<media>_SUPPORT as it is the first thing SPL searches for.
>
> Yes, but this is different from just migrating everything into Kconfig.
> I said this in another part of the series but I think we need to start
> by getting the options in and then as a follow-up to get depends/selects
> added.

Yes I agree. What is the status of this work? As it happened I ran
into this with some 64-bit x86 work recently and have created a series
that converts all the SPL_..._SUPPORT options to Kconfig. But it has
build errors which I have to resolve. I'll see if I can fix it up and
send it out

It would be good to fix the conflation of driver support with loading
from that driver, but that will be easier once things are in Kconfig.

>
> --
> Tom

Regards,
Simon