[U-Boot] [PATCH 01/13] spl: Kconfig: Add SPL__SUPPORT as Kconfig option

Heiko Schocher
2016-08-19T06:27:16Z

Hello Andrew,

first thanks for this series!

Am 18.08.2016 um 17:41 schrieb Andrew F. Davis:
> Create a new Kconfig file to contain SPL boot media loading support
> options as we begin moving these to the Kconfig system and out of header
> files. Initially add new configs for all the existing boot media types,
> giving them the same definition name as before to allow compatibility
> with systems not yet using Kconfig.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> common/Kconfig | 7 +++++++
> common/spl/Kconfig | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 61 insertions(+)
> create mode 100644 common/spl/Kconfig
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 46e7173..f594db5 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -156,6 +156,13 @@ config SPI_BOOT
> booted via SPI flash. This is not a must, some SoCs need this,
> somes not.
>
> +menu "SPL Media Loading Support"
> + depends on SPL
> +
> +source "common/spl/Kconfig"
> +
> +endmenu
> +
> endmenu
>
> config BOOTDELAY
> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> new file mode 100644
> index 0000000..788ca14
> --- /dev/null
> +++ b/common/spl/Kconfig
> @@ -0,0 +1,54 @@
> +config SPL_YMODEM_SUPPORT
> + depends on SPL
> + bool "SPL Support for loading next stage from UART"
> + help
> + This option enables SPL to load the next stage bootloader
> + over a UART line using the x/y/z/modem protocol.
> +
> +config SPL_MMC_SUPPORT
> + bool "SPL Support for loading next stage from SD/MMC/eMMC"
> + help
> + This option enables SPL to load the next stage bootloader
> + from an SD/MMC/eMMC device.

Hmm.. why do you not move, for existing board configs, which use
this symbols, them into their defconfigs? There is the great
script from Masahiro

u-boot:tools/moveconfig.py

which should do the most things for you ... also there is a tbot
testcase, with which you can test, that your new patch(es) do not
break an existing board, see for interests:

http://lists.denx.de/pipermail/u-boot/2016-June/258119.html

Same comment applies for your patches:
[U-Boot] [PATCH 02/13] spl: Kconfig: Add SPL_<media>_BOOT as Kconfig option
[U-Boot] [PATCH 03/13] spl: Kconfig: Add CONFIG_SPL_TEXT_BASE as Kconfig option

May you want to try it? If you have problems, feel free to contact me.

bye,
Heiko

> +
> +config SPL_SPI_SUPPORT
> + bool "SPL Support for loading next stage from SPI flash"
> + help
> + This option enables SPL to load the next stage bootloader
> + from SPI flash.
> +
> +config SPL_USB_SUPPORT
> + bool "SPL Support for loading next stage from USB"
> + help
> + This option enables SPL to load the next stage bootloader
> + from a USB device.
> +
> +config SPL_SATA_SUPPORT
> + bool "SPL Support for loading next stage from SATA"
> + help
> + This option enables SPL to load the next stage bootloader
> + from a SATA device.
> +
> +config SPL_NOR_SUPPORT
> + bool "SPL Support for loading next stage from NOR flash"
> + help
> + This option enables SPL to load the next stage bootloader
> + from NOR flash.
> +
> +config SPL_NAND_SUPPORT
> + bool "SPL Support for loading next stage from NAND flash"
> + help
> + This option enables SPL to load the next stage bootloader
> + from NAND flash.
> +
> +config SPL_ONENAND_SUPPORT
> + bool "SPL Support for loading next stage from ONENAND"
> + help
> + This option enables SPL to load the next stage bootloader
> + from ONENAND.
> +
> +config SPL_NET_SUPPORT
> + bool "SPL Support for loading next stage from NET"
> + help
> + This option enables SPL to load the next stage bootloader
> + from NET.
>

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany