From: John Keeping <john@metanate.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] rockchip: i2c: use named constant when appropriate
Date: Thu, 18 Aug 2016 20:08:40 +0100 [thread overview]
Message-ID: <20160818190842.25094-2-john@metanate.com> (raw)
In-Reply-To: <20160818190842.25094-1-john@metanate.com>
Make it clear that we are using the same value in two adjacent lines.
Signed-off-by: John Keeping <john@metanate.com>
---
drivers/i2c/rk_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/rk_i2c.c b/drivers/i2c/rk_i2c.c
index 63b1418..2597970 100644
--- a/drivers/i2c/rk_i2c.c
+++ b/drivers/i2c/rk_i2c.c
@@ -258,7 +258,7 @@ static int rk_i2c_write(struct rk_i2c *i2c, uchar chip, uint reg, uint r_len,
while (bytes_remain_len) {
if (bytes_remain_len > RK_I2C_FIFO_SIZE)
- bytes_xferred = 32;
+ bytes_xferred = RK_I2C_FIFO_SIZE;
else
bytes_xferred = bytes_remain_len;
words_xferred = DIV_ROUND_UP(bytes_xferred, 4);
--
2.9.3.728.g30b24b4.dirty
next prev parent reply other threads:[~2016-08-18 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 19:08 [U-Boot] [PATCH 0/3] rockchip: i2c: fix >32 byte writes John Keeping
2016-08-18 19:08 ` John Keeping [this message]
2016-09-06 1:03 ` [U-Boot] [PATCH 1/3] rockchip: i2c: use named constant when appropriate Simon Glass
2016-08-18 19:08 ` [U-Boot] [PATCH 2/3] rockchip: i2c: move register write out of inner loop John Keeping
2016-09-06 1:03 ` Simon Glass
2016-08-18 19:08 ` [U-Boot] [PATCH 3/3] rockchip: i2c: fix >32 byte writes John Keeping
2016-09-06 1:03 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818190842.25094-2-john@metanate.com \
--to=john@metanate.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox