From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] tools: moveconfig: warn loudly if moved option has no entry in Kconfig
Date: Mon, 22 Aug 2016 10:43:47 -0400 [thread overview]
Message-ID: <20160822144347.GE5342@bill-the-cat> (raw)
In-Reply-To: <1471871902-5361-4-git-send-email-yamada.masahiro@socionext.com>
On Mon, Aug 22, 2016 at 10:18:21PM +0900, Masahiro Yamada wrote:
> Currently, the tool gives up moving an option quietly if its entry
> was not found in Kconfig.
>
> If the option is not defined in the config header in the first
> place, it is no problem (as the Kconfig entry may have been hidden
> by reasonable "depends on").
>
> However, if the option is defined in the config header, the missing
> Kconfig entry is a sign of possible behavior change. It is highly
> recommended to manually check if the option has been moved as
> expected. In this case, let's add "suspicious" in the log and
> change the log color (if --color option is given) to make it stand
> out.
>
> This was suggested by Tom in [1].
>
> [1] http://lists.denx.de/pipermail/u-boot/2016-July/261988.html
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Suggested-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160822/c9267d6e/attachment.sig>
next prev parent reply other threads:[~2016-08-22 14:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 13:18 [U-Boot] [PATCH 0/4] tools: moveconfig: some more improvements Masahiro Yamada
2016-08-22 13:18 ` [U-Boot] [PATCH 1/4] tools: moveconfig: remove document about deprecated error message Masahiro Yamada
2016-08-22 18:12 ` Joe Hershberger
2016-09-07 17:57 ` [U-Boot] [U-Boot, " Tom Rini
2016-08-22 13:18 ` [U-Boot] [PATCH 2/4] tools: moveconfig: use sets instead of lists for failed/suspicious boards Masahiro Yamada
2016-08-22 18:13 ` Joe Hershberger
2016-09-07 17:58 ` [U-Boot] [U-Boot, " Tom Rini
2016-08-22 13:18 ` [U-Boot] [PATCH 3/4] tools: moveconfig: warn loudly if moved option has no entry in Kconfig Masahiro Yamada
2016-08-22 14:43 ` Tom Rini [this message]
2016-09-07 17:58 ` [U-Boot] [U-Boot, " Tom Rini
2016-08-22 13:18 ` [U-Boot] [PATCH 4/4] tools: moveconfig: add --spl option to move options for SPL build Masahiro Yamada
2016-08-22 14:43 ` Tom Rini
2016-08-22 14:57 ` Andrew F. Davis
2016-08-23 0:41 ` Masahiro Yamada
2016-09-07 17:58 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822144347.GE5342@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox