From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] configs: ti: armv7_common: Enable DISPLAY_{CPU/BOARD}INFO
Date: Sun, 28 Aug 2016 16:16:17 -0400 [thread overview]
Message-ID: <20160828201617.GA8799@bill-the-cat> (raw)
In-Reply-To: <20160827115355.26063-3-lokeshvutla@ti.com>
On Sat, Aug 27, 2016 at 05:23:55PM +0530, Lokesh Vutla wrote:
> Enable CONFIG_DISPLAY_{CPU/BOARD}INFO on all TI platforms.
> Also removing the duplicated configs.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> include/configs/ti_armv7_common.h | 4 ++++
> include/configs/ti_armv7_keystone2.h | 1 -
> include/configs/ti_omap4_common.h | 2 --
> include/configs/ti_omap5_common.h | 3 ---
> 4 files changed, 4 insertions(+), 6 deletions(-)
This is the wrong direction. Please add an entry to common/Kconfig (a
"hidden" one) and select it from board/ti/*/Kconfig. And this will need
some cleaning up of some other boards/ Kconfig files that introduced it
locally and instead should select this new option. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160828/e19e7891/attachment.sig>
next prev parent reply other threads:[~2016-08-28 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 11:53 [U-Boot] [PATCH 0/2] ARM: TI: Enable DISPLAY_{CPU/BOARD}INFO Lokesh Vutla
2016-08-27 11:53 ` [U-Boot] [PATCH 1/2] ARM: AM437X: Add Silicon ID support Lokesh Vutla
2016-08-27 11:53 ` [U-Boot] [PATCH 2/2] configs: ti: armv7_common: Enable DISPLAY_{CPU/BOARD}INFO Lokesh Vutla
2016-08-28 20:16 ` Tom Rini [this message]
2016-08-29 4:11 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160828201617.GA8799@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox