[U-Boot] [PATCH v3 08/13] ext4: do not clear zalloc'ed buffers a second time

Lukasz Majewski
2016-08-29T14:04:51Z

Hi Stefan,

> zero_buffer is never written, thus clearing it is pointless.
> journal_buffer is completely initialized by ext4fs_devread (or in case
> of failure, not used).
>
> Signed-off-by: Stefan Br?ns <stefan.bruens@rwth-aachen.de>
> ---
> fs/ext4/ext4_common.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> v3: Patch added to series
>
> diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c
> index 0018937..1ebdbe6 100644
> --- a/fs/ext4/ext4_common.c
> +++ b/fs/ext4/ext4_common.c
> @@ -921,7 +921,6 @@ restart:
>
> if (le16_to_cpu(bgd[bg_idx].bg_flags) &
> EXT4_BG_BLOCK_UNINIT) { uint16_t new_flags;
> - memset(zero_buffer, '\0', fs->blksz);
> put_ext4((uint64_t)le32_to_cpu(bgd[bg_idx].block_id)
> * fs->blksz, zero_buffer, fs->blksz);
> memcpy(fs->blk_bmaps[bg_idx], zero_buffer,
> fs->blksz); @@ -938,7 +937,6 @@ restart:
>
> /* journal backup */
> if (prev_bg_bitmap_index != bg_idx) {
> - memset(journal_buffer, '\0', fs->blksz);
> status = ext4fs_devread(
> (lbaint_t)le32_to_cpu(bgd[bg_idx].block_id)
> * fs->sect_perblk,
> @@ -1032,7 +1030,6 @@ restart:
> ibmap_idx = fs->curr_inode_no / inodes_per_grp;
> if (le16_to_cpu(bgd[ibmap_idx].bg_flags) &
> EXT4_BG_INODE_UNINIT) { int new_flags;
> - memset(zero_buffer, '\0', fs->blksz);
> put_ext4((uint64_t)le32_to_cpu(bgd[ibmap_idx].inode_id)
> * fs->blksz, zero_buffer, fs->blksz);
> new_flags =
> le16_to_cpu(bgd[ibmap_idx].bg_flags) & ~EXT4_BG_INODE_UNINIT;

Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>

--
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group