From: Vignesh R <vigneshr@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] spi: ti_qspi: Remove unnecessary udelay for AM437x
Date: Thu, 1 Sep 2016 13:24:40 +0530 [thread overview]
Message-ID: <20160901075440.29943-3-vigneshr@ti.com> (raw)
In-Reply-To: <20160901075440.29943-1-vigneshr@ti.com>
This udelay() was added as an HACK and is no longer required. All
read/write/erase operations work fine even without this delay. Hence,
remove the udelay() call.
Tested read/write/erase operation on AM437x SK. Also tested QSPI Boot.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
drivers/spi/ti_qspi.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/spi/ti_qspi.c b/drivers/spi/ti_qspi.c
index fe2a280cc7ae..1c215a0f89e2 100644
--- a/drivers/spi/ti_qspi.c
+++ b/drivers/spi/ti_qspi.c
@@ -225,13 +225,6 @@ static int __ti_qspi_xfer(struct ti_qspi_priv *priv, unsigned int bitlen,
priv->cmd |= QSPI_3_PIN;
priv->cmd |= 0xfff;
-/* FIXME: This delay is required for successfull
- * completion of read/write/erase. Once its root
- * caused, it will be remove from the driver.
- */
-#ifdef CONFIG_AM43XX
- udelay(100);
-#endif
while (words) {
u8 xfer_len = 0;
--
2.9.3
next prev parent reply other threads:[~2016-09-01 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 7:54 [U-Boot] [PATCH 0/2] spi: ti_qspi: Increase write speed Vignesh R
2016-09-01 7:54 ` [U-Boot] [PATCH 1/2] spi: ti_qspi: use 128 bit transfer mode when writing to flash Vignesh R
2016-09-02 14:54 ` Tom Rini
2016-09-04 14:21 ` Jagan Teki
2016-09-06 5:09 ` Vignesh R
2016-09-01 7:54 ` Vignesh R [this message]
2016-09-02 14:54 ` [U-Boot] [PATCH 2/2] spi: ti_qspi: Remove unnecessary udelay for AM437x Tom Rini
2016-09-04 13:55 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901075440.29943-3-vigneshr@ti.com \
--to=vigneshr@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox