From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 6 Sep 2016 09:34:49 -0400 Subject: [U-Boot] [PATCH v2 2/7] arm: mach-keystone: Implements FIT post-processing call for keystone SoCs In-Reply-To: <1472706282-6772-3-git-send-email-madans@ti.com> References: <1472706282-6772-1-git-send-email-madans@ti.com> <1472706282-6772-3-git-send-email-madans@ti.com> Message-ID: <20160906133449.GJ4990@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Sep 01, 2016 at 01:04:37AM -0400, Madan Srinivas wrote: > From: Vitaly Andrianov > > This commit implements the board_fit_image_post_process() function for > the keystone architecture. Unlike OMAP class devices, security > functions in keystone are not handled in the ROM. > The interface to the secure functions is TI proprietary and depending > on the keystone platform, the security functions like encryption, > decryption and authentication might even be offloaded to other secure > processing elements in the SoC. > The boot monitor acts as the gateway to these secure functions and the > boot monitor for secure devices is available as part of the SECDEV > package for KS2. For more details refer doc/README.ti-secure > > Signed-off-by: Vitaly Andrianov > Signed-off-by: Madan Srinivas > > Cc: Lokesh Vutla > Cc: Dan Murphy First, what is done to ensure that the magic blob we're offloading to isn't malicious? Second, this appears to be missing cache flushes that're done in arch/arm/cpu/armv7/omap-common/sec-common.c and, well, why can't we re-use the existing code? Given how rarely IP blocks are written from scratch rather than being an evolution of a previous block I can't imagine that we can't make the code there be re-used nor that we don't need / couldn't use the flushing and alignment checks nor status messages. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: