From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 01/44] Correct defconfigs using savedefconfig
Date: Wed, 7 Sep 2016 09:05:48 -0400 [thread overview]
Message-ID: <20160907130548.GH4990@bill-the-cat> (raw)
In-Reply-To: <CAK7LNAR7dWGac=eP_9FngKhbs8Ji_=tgyvN4AMu51=af19d0Vw@mail.gmail.com>
On Wed, Sep 07, 2016 at 01:03:23PM +0900, Masahiro Yamada wrote:
> 2016-09-07 3:01 GMT+09:00 Tom Rini <trini@konsulko.com>:
> > On Mon, Sep 05, 2016 at 11:47:00AM +0900, Masahiro Yamada wrote:
> >> 2016-08-30 9:21 GMT+09:00 Simon Glass <sjg@chromium.org>:
> >> > Update the defconfig files to match their canonical form, as produced by
> >> > 'make safedefconfig'.
> >> >
> >> > This is the result of running 'tools/moveconfig.py -s' on the tree.
> >> >
> >> > Signed-off-by: Simon Glass <sjg@chromium.org>
> >>
> >> >
> >> > diff --git a/configs/10m50_defconfig b/configs/10m50_defconfig
> >> > index 15952af..0e3ad96 100644
> >> > --- a/configs/10m50_defconfig
> >> > +++ b/configs/10m50_defconfig
> >> > @@ -1,7 +1,7 @@
> >> > CONFIG_NIOS2=y
> >> > CONFIG_SYS_CONFIG_NAME="10m50_devboard"
> >> > -CONFIG_DM_SERIAL=y
> >> > CONFIG_DM_GPIO=y
> >> > +CONFIG_DM_SERIAL=y
> >> > CONFIG_DEFAULT_DEVICE_TREE="10m50_devboard"
> >> > CONFIG_FIT=y
> >> > CONFIG_OF_BOARD_SETUP=y
> >> > diff --git a/configs/3c120_defconfig b/configs/3c120_defconfig
> >> > index b19c956..0c3fbde 100644
> >> > --- a/configs/3c120_defconfig
> >> > +++ b/configs/3c120_defconfig
> >> > @@ -1,7 +1,7 @@
> >> > CONFIG_NIOS2=y
> >> > CONFIG_SYS_CONFIG_NAME="3c120_devboard"
> >> > -CONFIG_DM_SERIAL=y
> >> > CONFIG_DM_GPIO=y
> >> > +CONFIG_DM_SERIAL=y
> >> > CONFIG_DEFAULT_DEVICE_TREE="3c120_devboard"
> >> > CONFIG_FIT=y
> >> > CONFIG_OF_BOARD_SETUP=y
> >>
> >>
> >>
> >> If the following patch is applied
> >> http://patchwork.ozlabs.org/patch/664076/
> >> the savedefconfig sync will produce completely different
> >> results for these defconfigs.
> >>
> >>
> >> The "make savedefconfig" sorts CONFIGs
> >> in the order as Kconfig entries are parsed.
> >>
> >> In other words, the canonical order changes
> >> every time bare default entries are added/removed
> >> in board/*/Kconfig.
> >>
> >>
> >> We are just repeating mad churn...
> >
> > Yes, but it's churn we have to live with until everything is migrated,
> > no?
> >
>
> I am OK with adding CONFIG to defconfig files.
>
> But I often see CONFIGs moving up/down
> every time we sync defconfigs,
> most of them are unrelated to what we want to move.
>
>
> The cause is that people often add
> config FOO
> default y
>
> around in board/*/Kconfig
> (and eventually I fix it).
OK, fair point, I need to be better about catching those when they sneak
in.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160907/3491010c/attachment.sig>
next prev parent reply other threads:[~2016-09-07 13:05 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 0:21 [U-Boot] [PATCH v2 00/44] Kconfig: Move CONFIG_SPL_..._SUPPORT to Kconfig Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 01/44] Correct defconfigs using savedefconfig Simon Glass
2016-09-05 2:47 ` Masahiro Yamada
2016-09-06 18:01 ` Tom Rini
2016-09-06 18:08 ` Simon Glass
2016-09-07 4:03 ` Masahiro Yamada
2016-09-07 13:05 ` Tom Rini [this message]
2016-09-08 9:24 ` Masahiro Yamada
2016-08-30 0:21 ` [U-Boot] [PATCH v2 02/44] moveconfig: Add an option to skip prompts Simon Glass
2016-08-30 3:41 ` Masahiro Yamada
2016-08-30 0:21 ` [U-Boot] [PATCH v2 03/44] moveconfig: Add an option to commit changes Simon Glass
2016-08-30 4:00 ` Masahiro Yamada
2016-08-30 0:21 ` [U-Boot] [PATCH v2 04/44] Kconfig: Move SPL settings into their own file Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 05/44] arm: fsl: Adjust ordering of #ifndef CONFIG_SPL_BUILD Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 06/44] Drop CONFIG_SPL_RAM_SUPPORT Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 07/44] Use separate options for TPL support Simon Glass
2016-09-06 18:06 ` Tom Rini
2016-09-06 18:12 ` Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 08/44] Kconfig: spl: Add SPL support options to Kconfig Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 09/44] Kconfig: tpl: Add some TPL " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 10/44] Move existing use of CONFIG_SPL_DM " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 11/44] Move existing use of CONFIG_SPL_RSA " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 12/44] spear: Use upper case for CONFIG options Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 13/44] Convert CONFIG_SPL_CRYPTO_SUPPORT to Kconfig Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 14/44] Convert CONFIG_SPL_HASH_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 15/44] Convert CONFIG_SPL_DMA_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 16/44] Convert CONFIG_SPL_DRIVERS_MISC_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 17/44] Convert CONFIG_SPL_ENV_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 18/44] Convert CONFIG_SPL_ETH_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 19/44] Convert CONFIG_SPL_EXT_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 20/44] Convert CONFIG_SPL_FAT_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 21/44] Convert CONFIG_SPL_GPIO_SUPPORT " Simon Glass
2016-08-30 3:25 ` Masahiro Yamada
2016-08-30 18:33 ` Simon Glass
2016-09-02 14:35 ` Tom Rini
2016-09-05 2:40 ` Masahiro Yamada
2016-09-06 1:04 ` Simon Glass
2016-09-06 15:54 ` Tom Rini
2016-09-07 4:55 ` Masahiro Yamada
2016-09-12 4:16 ` Simon Glass
2016-09-12 4:32 ` Masahiro Yamada
2016-09-12 14:19 ` Tom Rini
2016-08-30 0:21 ` [U-Boot] [PATCH v2 22/44] Convert CONFIG_SPL_I2C_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 23/44] Convert CONFIG_SPL_LIBCOMMON_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 24/44] Convert CONFIG_SPL_LIBDISK_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 25/44] Convert CONFIG_SPL_LIBGENERIC_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 26/44] Convert CONFIG_SPL_MMC_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 27/44] Convert CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 28/44] Convert CONFIG_SPL_MTD_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 29/44] Convert CONFIG_SPL_MUSB_NEW_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 30/44] Convert CONFIG_SPL_NAND_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 31/44] Convert CONFIG_SPL_NET_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 32/44] Convert CONFIG_SPL_NOR_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 33/44] Convert CONFIG_SPL_ONENAND_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 34/44] Convert CONFIG_SPL_PINCTRL_SUPPORT " Simon Glass
2016-08-30 3:31 ` Masahiro Yamada
2016-08-30 0:21 ` [U-Boot] [PATCH v2 35/44] Convert CONFIG_SPL_POWER_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 36/44] Convert CONFIG_SPL_SATA_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 37/44] Convert CONFIG_SPL_SERIAL_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 38/44] Convert CONFIG_SPL_SPI_FLASH_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 39/44] Convert CONFIG_SPL_SPI_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 40/44] Convert CONFIG_SPL_USBETH_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 41/44] Convert CONFIG_SPL_USB_HOST_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 42/44] Convert CONFIG_SPL_USB_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 43/44] Convert CONFIG_SPL_WATCHDOG_SUPPORT " Simon Glass
2016-08-30 0:21 ` [U-Boot] [PATCH v2 44/44] Convert CONFIG_SPL_YMODEM_SUPPORT " Simon Glass
2016-08-30 5:28 ` [U-Boot] [PATCH v2 00/44] Kconfig: Move CONFIG_SPL_..._SUPPORT " Heiko Schocher
2016-09-06 1:04 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907130548.GH4990@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox