From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 8 Sep 2016 16:17:34 -0400 Subject: [U-Boot] config USB_STORAGE: defconfig vs include header In-Reply-To: <20160908181321.GI4990@bill-the-cat> References: <4ffdaf01-571b-8636-5261-90ba4568e349@wwwdotorg.org> <20160908181321.GI4990@bill-the-cat> Message-ID: <20160908201734.GR4990@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Sep 08, 2016 at 02:13:21PM -0400, Tom Rini wrote: > On Thu, Sep 08, 2016 at 09:58:13AM -0600, Stephen Warren wrote: > > On 09/07/2016 07:29 PM, Masahiro Yamada wrote: > > >Hi Stephen > > > > > > > > >2016-09-08 1:15 GMT+09:00 Stephen Warren : > > >>Masahiro, > > >> > > >>In patch 6e7e9294d321 "usb: add basic USB configs in Kconfig", you added > > >>"config USB_STORAGE" to drivers/usb/Kconfig. However, it's still just > > >>#defined by many include/configs/*.h rather than being defined in > > >>configs/*_defconfig. Is that a problem? It seems to work in practice, but > > >>leads people adding new boards to put the definition in configs/*_defconfig > > >>which then may be inconsistent with similar existing boards which have it > > >>defined in include/configs/*.h. > > > > > >Once we create an entry in Kconfig, > > >all the defines in include/configs/*.h should be moved. > > > > That's what I imagined. The commit above didn't do that though; are > > you planning on sending a fix? > > Since those are often conflict-happy I'll take care of it. I probably > intended to, even. So, yay for moveconfig.suspicious being a thing now. A number of boards set CONFIG_USB_STORAGE without CONFIG_USB=y in their defconfig file, so they lost CONFIG_USB_STORAGE in migration. Confirming that yes, really, nothing else is added or dropped when we set CONFIG_USB=y in the defconfig files as well (unit testing was good, testing the world now). -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: