From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] config USB_STORAGE: defconfig vs include header
Date: Thu, 8 Sep 2016 21:13:47 -0400 [thread overview]
Message-ID: <20160909011347.GU4990@bill-the-cat> (raw)
In-Reply-To: <CAK7LNAQNd_8UhEitwYb=Q=DNNX31F88LCq9L1FaeGVd76U9zfA@mail.gmail.com>
On Fri, Sep 09, 2016 at 10:09:56AM +0900, Masahiro Yamada wrote:
> 2016-09-09 5:17 GMT+09:00 Tom Rini <trini@konsulko.com>:
> > On Thu, Sep 08, 2016 at 02:13:21PM -0400, Tom Rini wrote:
> >> On Thu, Sep 08, 2016 at 09:58:13AM -0600, Stephen Warren wrote:
> >> > On 09/07/2016 07:29 PM, Masahiro Yamada wrote:
> >> > >Hi Stephen
> >> > >
> >> > >
> >> > >2016-09-08 1:15 GMT+09:00 Stephen Warren <swarren@wwwdotorg.org>:
> >> > >>Masahiro,
> >> > >>
> >> > >>In patch 6e7e9294d321 "usb: add basic USB configs in Kconfig", you added
> >> > >>"config USB_STORAGE" to drivers/usb/Kconfig. However, it's still just
> >> > >>#defined by many include/configs/*.h rather than being defined in
> >> > >>configs/*_defconfig. Is that a problem? It seems to work in practice, but
> >> > >>leads people adding new boards to put the definition in configs/*_defconfig
> >> > >>which then may be inconsistent with similar existing boards which have it
> >> > >>defined in include/configs/*.h.
> >> > >
> >> > >Once we create an entry in Kconfig,
> >> > >all the defines in include/configs/*.h should be moved.
> >> >
> >> > That's what I imagined. The commit above didn't do that though; are
> >> > you planning on sending a fix?
> >>
> >> Since those are often conflict-happy I'll take care of it. I probably
> >> intended to, even.
> >
> > So, yay for moveconfig.suspicious being a thing now. A number of boards
> > set CONFIG_USB_STORAGE without CONFIG_USB=y in their defconfig file, so
> > they lost CONFIG_USB_STORAGE in migration. Confirming that yes, really,
> > nothing else is added or dropped when we set CONFIG_USB=y in the
> > defconfig files as well (unit testing was good, testing the world now).
>
> I thought so.
>
> A little bit manual intervention
> is needed for those suspicious boards.
> (add CONFIGs by your own script and re-sync)
>
> I hope this is not too painful...
Nope, it was rather smooth and got me to notice another problem, that is
a little harder to solve "cleanly" until we have Simon's SPL series in.
> Thanks for taking care of this!
Thanks for making the tools!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160908/88e32ce7/attachment.sig>
prev parent reply other threads:[~2016-09-09 1:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 16:15 [U-Boot] config USB_STORAGE: defconfig vs include header Stephen Warren
2016-09-08 1:29 ` Masahiro Yamada
2016-09-08 15:58 ` Stephen Warren
2016-09-08 18:13 ` Tom Rini
2016-09-08 20:17 ` Tom Rini
2016-09-09 1:09 ` Masahiro Yamada
2016-09-09 1:13 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909011347.GU4990@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox