From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] fs/fat: Correct description of determine_fatent function
Date: Mon, 12 Sep 2016 13:04:33 +0200 [thread overview]
Message-ID: <20160912130433.47929656@amdc2363> (raw)
In-Reply-To: <4be1a696305f4df097068cbe965d7ae4@rwthex-w2-b.rwth-ad.de>
Hi Stefan,
> Current description does not match the function behaviour.
>
> Signed-off-by: Stefan Br?ns <stefan.bruens@rwth-aachen.de>
> ---
> fs/fat/fat_write.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c
> index babe9c8..0583af3 100644
> --- a/fs/fat/fat_write.c
> +++ b/fs/fat/fat_write.c
> @@ -528,7 +528,8 @@ static int set_fatent_value(fsdata *mydata, __u32
> entry, __u32 entry_value) }
>
> /*
> - * Determine the entry value at index 'entry' in a FAT (16/32) table
> + * Determine the next free cluster after 'entry' in a FAT (16/32)
> table
> + * and link it to 'entry'. EOC marker is not set on returned entry.
> */
> static __u32 determine_fatent(fsdata *mydata, __u32 entry)
> {
> @@ -537,6 +538,7 @@ static __u32 determine_fatent(fsdata *mydata,
> __u32 entry) while (1) {
> next_fat = get_fatent_value(mydata, next_entry);
> if (next_fat == 0) {
> + /* found free entry, link to entry */
> set_fatent_value(mydata, entry, next_entry);
> break;
> }
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2016-09-12 11:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160911205142.4259-1-stefan.bruens@rwth-aachen.de>
2016-09-11 20:51 ` [U-Boot] [PATCH 1/4] fs/fat: Remove two statements without effect Stefan Brüns
2016-09-12 10:43 ` Lukasz Majewski
2016-09-12 18:48 ` Stephen Warren
2016-09-12 20:15 ` Benoît Thébaudeau
2016-09-23 19:55 ` [U-Boot] [U-Boot, " Tom Rini
2016-09-11 20:51 ` [U-Boot] [PATCH 2/4] fs/fat: Do not write unmodified fat entries to disk Stefan Brüns
2016-09-12 10:56 ` Lukasz Majewski
2016-09-23 19:55 ` [U-Boot] [U-Boot, " Tom Rini
2016-09-11 20:51 ` [U-Boot] [PATCH 3/4] fs/fat: Correct description of determine_fatent function Stefan Brüns
2016-09-12 11:04 ` Lukasz Majewski [this message]
2016-09-23 19:55 ` [U-Boot] [U-Boot, " Tom Rini
2016-09-11 20:51 ` [U-Boot] [PATCH 4/4] cmd/fat: Do not crash on write when <bytes> is not specified Stefan Brüns
2016-09-19 0:57 ` Simon Glass
2016-09-23 19:55 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912130433.47929656@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox