From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Mon, 12 Sep 2016 13:04:33 +0200 Subject: [U-Boot] [PATCH 3/4] fs/fat: Correct description of determine_fatent function In-Reply-To: <4be1a696305f4df097068cbe965d7ae4@rwthex-w2-b.rwth-ad.de> References: <20160911205142.4259-1-stefan.bruens@rwth-aachen.de> <4be1a696305f4df097068cbe965d7ae4@rwthex-w2-b.rwth-ad.de> Message-ID: <20160912130433.47929656@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, > Current description does not match the function behaviour. > > Signed-off-by: Stefan Br?ns > --- > fs/fat/fat_write.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c > index babe9c8..0583af3 100644 > --- a/fs/fat/fat_write.c > +++ b/fs/fat/fat_write.c > @@ -528,7 +528,8 @@ static int set_fatent_value(fsdata *mydata, __u32 > entry, __u32 entry_value) } > > /* > - * Determine the entry value at index 'entry' in a FAT (16/32) table > + * Determine the next free cluster after 'entry' in a FAT (16/32) > table > + * and link it to 'entry'. EOC marker is not set on returned entry. > */ > static __u32 determine_fatent(fsdata *mydata, __u32 entry) > { > @@ -537,6 +538,7 @@ static __u32 determine_fatent(fsdata *mydata, > __u32 entry) while (1) { > next_fat = get_fatent_value(mydata, next_entry); > if (next_fat == 0) { > + /* found free entry, link to entry */ > set_fatent_value(mydata, entry, next_entry); > break; > } Acked-by: Lukasz Majewski -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group