From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 14 Sep 2016 16:31:47 +0200 Subject: [U-Boot] recommended place to add some custom settings to u-boot environment? In-Reply-To: References: <20160914091718.73124100BD9@atlas.denx.de> <20160914125839.C998A100BA3@atlas.denx.de> <20160914133336.4660A100BD9@atlas.denx.de> Message-ID: <20160914143147.0DC69100BA3@atlas.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Robert, In message you wrote: > > > It will not realy work. "space-separated" is not good enough as a > > space character is a legal part of the value of an environment > > variable. You would need to tweak the import code. > > but himport_r() explicitly takes a separator character, and i can > guarantee the strings being "imported" have no embedded space > characters in their values. so as long as that's the case, shouldn't > himport_r() properly handle that given a separator of space? Well, yes, but it sounds a bit fragile to me. Experience tells me that very soon someone _will_ use a space in a variable. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The scientists of today think deeply instead of clearly. One must be sane to think clearly, but one can think deeply and be quite insane. - Nikola Tesla