From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 6/8] imx: mx6ullevk: support plugin
Date: Tue, 27 Sep 2016 21:47:30 -0400 [thread overview]
Message-ID: <20160928014730.GE4884@bill-the-cat> (raw)
In-Reply-To: <20160928013120.GA26138@linux-7smt.suse>
On Wed, Sep 28, 2016 at 09:31:23AM +0800, Peng Fan wrote:
> Hi Tom,
> On Tue, Sep 27, 2016 at 08:46:32PM -0400, Tom Rini wrote:
> >On Tue, Sep 27, 2016 at 05:23:25PM +0800, Peng Fan wrote:
> >
> >> Add plugin code for mx6ullevk.
> >> Define CONFIG_USE_PLUGIN in include/configs/mx6ullevk.h to use plugin code.
> >
> >This isn't the correct thing to say now that it's in Kconfig.
>
> Thanks, I missed to change this.
>
> Stefano, would you mind help change the commit log
> to "Define CONFIG_USE_IMXIMG_PLUGIN in defconfig file to use plugin code"
> when you commit this patch? do you need me to resend a V3?
>
> >
> >>
> >> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >> Cc: Stefano Babic <sbabic@denx.de>
> >> ---
> >>
> >> V2:
> >> Drop the makefile changes, because we have plugin supported in arch/arm/imx-common/Makefile.
> >>
> >> board/freescale/mx6ullevk/imximage.cfg | 2 +-
> >> board/freescale/mx6ullevk/plugin.S | 139 +++++++++++++++++++++++++++++++++
> >> 2 files changed, 140 insertions(+), 1 deletion(-)
> >> create mode 100644 board/freescale/mx6ullevk/plugin.S
> >>
> >> diff --git a/board/freescale/mx6ullevk/imximage.cfg b/board/freescale/mx6ullevk/imximage.cfg
> >> index 4604b62..1a21b49 100644
> >> --- a/board/freescale/mx6ullevk/imximage.cfg
> >> +++ b/board/freescale/mx6ullevk/imximage.cfg
> >> @@ -29,7 +29,7 @@ BOOT_FROM nor
> >> BOOT_FROM sd
> >> #endif
> >>
> >> -#ifdef CONFIG_USE_PLUGIN
> >> +#ifdef CONFIG_USE_IMXIMG_PLUGIN
> >
> >We don't have this file yet, and shouldn't introduce it with a new
> >CONFIG symbol. So the imx6ullevk series needs to be re-worked to just
> >not have this hunk, and we introduce it in this series here.
>
> I missed to drop this when posting out the mx6ull patches,
> since they are already in imx next tree, so I worked out this patch set
> based on imx-next tree.
Ah, OK. If Stefano is OK with re-wording the commit, I'm otherwise OK.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160927/2540b103/attachment.sig>
next prev parent reply other threads:[~2016-09-28 1:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 9:23 [U-Boot] [PATCH V2 1/8] tools: imximage: add plugin support Peng Fan
2016-09-27 9:23 ` [U-Boot] [PATCH V2 2/8] imx: mx6: Add " Peng Fan
2016-09-28 0:46 ` Tom Rini
2016-09-28 3:14 ` Utkarsh Gupta
2016-09-27 9:23 ` [U-Boot] [PATCH V2 3/8] imx: mx7: " Peng Fan
2016-09-28 0:46 ` Tom Rini
2016-09-27 9:23 ` [U-Boot] [PATCH V2 4/8] imx-common: inctroude USE_IMXIMG_PLUGIN Kconfig Peng Fan
2016-09-28 0:46 ` Tom Rini
2016-09-27 9:23 ` [U-Boot] [PATCH V2 5/8] imx-common: compile plugin code Peng Fan
2016-09-28 0:46 ` Tom Rini
2016-09-27 9:23 ` [U-Boot] [PATCH V2 6/8] imx: mx6ullevk: support plugin Peng Fan
2016-09-28 0:46 ` Tom Rini
2016-09-28 1:31 ` Peng Fan
2016-09-28 1:47 ` Tom Rini [this message]
2016-09-27 9:23 ` [U-Boot] [PATCH V2 7/8] imx: mx6ullevk: correct boot device macro Peng Fan
2016-09-27 9:23 ` [U-Boot] [PATCH V2 8/8] imx: mx6ull_14x14_evk: add plugin defconfig Peng Fan
2016-09-28 0:46 ` [U-Boot] [PATCH V2 1/8] tools: imximage: add plugin support Tom Rini
2016-10-04 8:17 ` Stefano Babic
2016-10-04 17:54 ` Stefano Babic
2016-10-08 1:27 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928014730.GE4884@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox