public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb:gadget: Disallow DFU in SPL for now
Date: Wed, 28 Sep 2016 11:19:36 +0200	[thread overview]
Message-ID: <20160928111936.3377771e@amdc2363> (raw)
In-Reply-To: <1474987320-26982-1-git-send-email-trini@konsulko.com>

Hi Tom,

> Previously, DFU was not built in for SPL and often disabled via the
> board config.h file, in the SPL build.  By moving DFU to Kconfig we
> now need to move this logic to the Makefile to continue to allow
> boards to fit within their SPL size limit (until gcc 6 is more
> widespread and unused strings will be discarded).
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Without this, but everything converted am335x_evm_usbspl fails to
> link (does gadget USB in SPL) unless we make drivers/dfu/
> unconditional.  This however breaks a few other platforms that have a
> smaller SPL size due to undiscarded strings, and a lot of other
> platforms just grow by a few KiB.  This is the best solution I can
> come up with for now.

Ok, lets disable it (hopefully for now).

> 
>  drivers/usb/gadget/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
> index c915c79..acc9964 100644
> --- a/drivers/usb/gadget/Makefile
> +++ b/drivers/usb/gadget/Makefile
> @@ -19,7 +19,9 @@ obj-$(CONFIG_USB_GADGET_FOTG210) += fotg210.o
>  obj-$(CONFIG_CI_UDC)	+= ci_udc.o
>  obj-$(CONFIG_USB_GADGET_DOWNLOAD) += g_dnl.o
>  obj-$(CONFIG_USB_FUNCTION_THOR) += f_thor.o
> +ifndef CONFIG_SPL_BUILD
>  obj-$(CONFIG_USB_FUNCTION_DFU) += f_dfu.o
> +endif
>  obj-$(CONFIG_USB_FUNCTION_MASS_STORAGE) += f_mass_storage.o
>  obj-$(CONFIG_USB_FUNCTION_FASTBOOT) += f_fastboot.o
>  endif



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

      parent reply	other threads:[~2016-09-28  9:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20160927144243eucas1p1d24615fc2dc953b0961b2c9b4f63723b@eucas1p1.samsung.com>
2016-09-27 14:42 ` [U-Boot] [PATCH] usb:gadget: Disallow DFU in SPL for now Tom Rini
2016-09-27 21:34   ` Tom Rini
2016-09-28  9:19   ` Lukasz Majewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160928111936.3377771e@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox