* [U-Boot] [PATCH] usb:gadget: Disallow DFU in SPL for now
@ 2016-09-27 14:42 ` Tom Rini
2016-09-27 21:34 ` Tom Rini
2016-09-28 9:19 ` Lukasz Majewski
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rini @ 2016-09-27 14:42 UTC (permalink / raw)
To: u-boot
Previously, DFU was not built in for SPL and often disabled via the board
config.h file, in the SPL build. By moving DFU to Kconfig we now need to
move this logic to the Makefile to continue to allow boards to fit within
their SPL size limit (until gcc 6 is more widespread and unused strings will
be discarded).
Signed-off-by: Tom Rini <trini@konsulko.com>
---
Without this, but everything converted am335x_evm_usbspl fails to link (does
gadget USB in SPL) unless we make drivers/dfu/ unconditional. This however
breaks a few other platforms that have a smaller SPL size due to undiscarded
strings, and a lot of other platforms just grow by a few KiB. This is the best
solution I can come up with for now.
drivers/usb/gadget/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
index c915c79..acc9964 100644
--- a/drivers/usb/gadget/Makefile
+++ b/drivers/usb/gadget/Makefile
@@ -19,7 +19,9 @@ obj-$(CONFIG_USB_GADGET_FOTG210) += fotg210.o
obj-$(CONFIG_CI_UDC) += ci_udc.o
obj-$(CONFIG_USB_GADGET_DOWNLOAD) += g_dnl.o
obj-$(CONFIG_USB_FUNCTION_THOR) += f_thor.o
+ifndef CONFIG_SPL_BUILD
obj-$(CONFIG_USB_FUNCTION_DFU) += f_dfu.o
+endif
obj-$(CONFIG_USB_FUNCTION_MASS_STORAGE) += f_mass_storage.o
obj-$(CONFIG_USB_FUNCTION_FASTBOOT) += f_fastboot.o
endif
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] usb:gadget: Disallow DFU in SPL for now
2016-09-27 14:42 ` [U-Boot] [PATCH] usb:gadget: Disallow DFU in SPL for now Tom Rini
@ 2016-09-27 21:34 ` Tom Rini
2016-09-28 9:19 ` Lukasz Majewski
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-09-27 21:34 UTC (permalink / raw)
To: u-boot
On Tue, Sep 27, 2016 at 10:42:00AM -0400, Tom Rini wrote:
> Previously, DFU was not built in for SPL and often disabled via the board
> config.h file, in the SPL build. By moving DFU to Kconfig we now need to
> move this logic to the Makefile to continue to allow boards to fit within
> their SPL size limit (until gcc 6 is more widespread and unused strings will
> be discarded).
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160927/873bda89/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] usb:gadget: Disallow DFU in SPL for now
2016-09-27 14:42 ` [U-Boot] [PATCH] usb:gadget: Disallow DFU in SPL for now Tom Rini
2016-09-27 21:34 ` Tom Rini
@ 2016-09-28 9:19 ` Lukasz Majewski
1 sibling, 0 replies; 3+ messages in thread
From: Lukasz Majewski @ 2016-09-28 9:19 UTC (permalink / raw)
To: u-boot
Hi Tom,
> Previously, DFU was not built in for SPL and often disabled via the
> board config.h file, in the SPL build. By moving DFU to Kconfig we
> now need to move this logic to the Makefile to continue to allow
> boards to fit within their SPL size limit (until gcc 6 is more
> widespread and unused strings will be discarded).
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Without this, but everything converted am335x_evm_usbspl fails to
> link (does gadget USB in SPL) unless we make drivers/dfu/
> unconditional. This however breaks a few other platforms that have a
> smaller SPL size due to undiscarded strings, and a lot of other
> platforms just grow by a few KiB. This is the best solution I can
> come up with for now.
Ok, lets disable it (hopefully for now).
>
> drivers/usb/gadget/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
> index c915c79..acc9964 100644
> --- a/drivers/usb/gadget/Makefile
> +++ b/drivers/usb/gadget/Makefile
> @@ -19,7 +19,9 @@ obj-$(CONFIG_USB_GADGET_FOTG210) += fotg210.o
> obj-$(CONFIG_CI_UDC) += ci_udc.o
> obj-$(CONFIG_USB_GADGET_DOWNLOAD) += g_dnl.o
> obj-$(CONFIG_USB_FUNCTION_THOR) += f_thor.o
> +ifndef CONFIG_SPL_BUILD
> obj-$(CONFIG_USB_FUNCTION_DFU) += f_dfu.o
> +endif
> obj-$(CONFIG_USB_FUNCTION_MASS_STORAGE) += f_mass_storage.o
> obj-$(CONFIG_USB_FUNCTION_FASTBOOT) += f_fastboot.o
> endif
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-28 9:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20160927144243eucas1p1d24615fc2dc953b0961b2c9b4f63723b@eucas1p1.samsung.com>
2016-09-27 14:42 ` [U-Boot] [PATCH] usb:gadget: Disallow DFU in SPL for now Tom Rini
2016-09-27 21:34 ` Tom Rini
2016-09-28 9:19 ` Lukasz Majewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox