From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 11/12] RFC: Use binman for a sunxi board
Date: Sat, 1 Oct 2016 20:46:37 -0400 [thread overview]
Message-ID: <20161002004637.GW4884@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ3LsStLSAc4oMx=cyRS3oWysm9r-q0DTOU++pKFG1vn7g@mail.gmail.com>
On Sat, Oct 01, 2016 at 06:29:42PM -0600, Simon Glass wrote:
> Hi Tom,
>
> On 1 October 2016 at 18:15, Tom Rini <trini@konsulko.com> wrote:
> > On Wed, Sep 28, 2016 at 09:46:25AM -0600, Simon Glass wrote:
> >> Hi Tom,
> >>
> >> On 27 September 2016 at 19:55, Tom Rini <trini@konsulko.com> wrote:
> >> > On Sun, Sep 25, 2016 at 03:52:27PM -0600, Simon Glass wrote:
> >> >
> >> >> Add an example usage of binman for a sunxi board. This involves adding the
> >> >> image definition to the device tree and using it in the Makefile.
> >> >>
> >> >> This is for example only.
> >> >>
> >> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >> >> ---
> >> >>
> >> >> Changes in v2: None
> >> >>
> >> >> Makefile | 4 +---
> >> >> arch/arm/dts/sun7i-a20-pcduino3.dts | 12 ++++++++++++
> >> >
> >> > I think this shows the big problem with using binman today. For the
> >> > common case of ARM, where we sync in the dts* files from upstream, this
> >> > will add hunks that must not be overwritten each time.
> >> >
> >> > Looking at scripts/Makefile.lib::cmd_fdt I wonder if we couldn't come up
> >> > with some wildcard rule and check if, somewhere CONFIG'd ? $(BOARDDIR)/
> >> > ? u-boot.dtsi exists add in -include that/file.dtsi to the CPP rule so
> >> > that we can keep the parts that will never get upstream separate.
> >>
> >> We can do that, but I have found that most boards with the same SoC
> >> are the same, or similar. So for x86 [1] I put it in a separate patch
> >> with just an #include in the .dts file.
> >>
> >> We could have binman be a bit smarter about where it looks - e.g. if
> >> there is no binman node, it could look in the same directory for a
> >> file that matches the board name, or part of it?
> >
> > I'd really like to try and better solve the generic problem we have tho
> > too while we're at it. ie the u-boot,dm-pre-reloc tag on various nodes
> > could also go into this file.
>
> What sort of solution are you thinking of? A U-Boot .dtsi include that
> is #included at the top of all files?
Something like:
ifneq ($(wildcard $(srctree)/arch/$(CONFIG_SYS_ARCH)/cpu/$(CONFIG_SYS_CPU)/$(CONFIG_SYS_SOC)/u-boot.dtsi),)
dtc_cpp_flags += -include
$(srctree)/arch/$(CONFIG_SYS_ARCH)/cpu/$(CONFIG_SYS_CPU)/$(CONFIG_SYS_SOC)/u-boot.dtsi
endif
And maybe a few other wildcards, I'm not sure, so that for everything
rockchip related, ie what binman needs, what nodes need to be pre-reloc,
etc, can end up in that one file. And we use -include to get it so that
arch/arm/dts/ can be unmodified from upstream.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161001/126726df/attachment.sig>
next prev parent reply other threads:[~2016-10-02 0:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 21:52 [U-Boot] [PATCH v2 00/12] binman: A tool for creating firmware images Simon Glass
2016-09-25 21:52 ` [U-Boot] [PATCH v2 01/12] dtoc: Fix bug in GetProp() Simon Glass
2016-10-02 17:58 ` Simon Glass
2016-09-25 21:52 ` [U-Boot] [PATCH v2 02/12] dtoc: Adjust GetProps() in fdt_normal to use the node path Simon Glass
2016-10-02 17:58 ` Simon Glass
2016-09-25 21:52 ` [U-Boot] [PATCH v2 03/12] dtoc: Add a way for tests to request the fallback library Simon Glass
2016-10-02 17:58 ` Simon Glass
2016-09-25 21:52 ` [U-Boot] [PATCH v2 04/12] binman: Introduce binman, a tool for building binary images Simon Glass
2016-09-25 21:52 ` [U-Boot] [PATCH v2 05/12] binman: Add basic entry types for U-Boot Simon Glass
2016-09-25 21:52 ` [U-Boot] [PATCH v2 06/12] binman: Add support for building x86 ROMs Simon Glass
2016-09-25 21:52 ` [U-Boot] [PATCH v2 07/12] binman: Add support for u-boot.img as an input binary Simon Glass
2016-09-25 21:52 ` [U-Boot] [PATCH v2 08/12] binman: Add support for building x86 ROMs with SPL Simon Glass
2016-09-25 21:52 ` [U-Boot] [PATCH v2 09/12] binman: Add a build rule for binman Simon Glass
2016-09-25 21:52 ` [U-Boot] [PATCH v2 10/12] binman: Allow configuration options to be used in .dts files Simon Glass
2016-09-25 21:52 ` [U-Boot] [PATCH v2 11/12] RFC: Use binman for a sunxi board Simon Glass
2016-09-28 1:55 ` Tom Rini
2016-09-28 15:46 ` Simon Glass
2016-10-02 0:15 ` Tom Rini
2016-10-02 0:29 ` Simon Glass
2016-10-02 0:46 ` Tom Rini [this message]
2016-10-03 3:26 ` Simon Glass
2016-10-05 16:50 ` Simon Glass
2016-09-25 21:52 ` [U-Boot] [PATCH v2 12/12] RFC: Use binman for an x86 board Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161002004637.GW4884@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox