* [U-Boot] [PATCH 1/2] sandbox, x86: select DM_KEYBOARD instead of default y entry
@ 2016-09-08 9:47 Masahiro Yamada
2016-09-08 9:47 ` [U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner Masahiro Yamada
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Masahiro Yamada @ 2016-09-08 9:47 UTC (permalink / raw)
To: u-boot
Once we migrate to DM-based drivers, we cannot go back to legacy
ones, i.e. config options like DM_* are not user-configurable.
Make SANDBOX and X86 select DM_KEYBOARD like other platforms do.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/Kconfig | 2 ++
arch/sandbox/Kconfig | 3 ---
arch/x86/Kconfig | 3 ---
3 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/Kconfig b/arch/Kconfig
index d718a68..ffc7b45 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -62,6 +62,7 @@ config SANDBOX
bool "Sandbox"
select SUPPORT_OF_CONTROL
select DM
+ select DM_KEYBOARD
select DM_SPI_FLASH
select DM_SERIAL
select DM_I2C
@@ -83,6 +84,7 @@ config X86
select HAVE_PRIVATE_LIBGCC
select SUPPORT_OF_CONTROL
select DM
+ select DM_KEYBOARD
select DM_SERIAL
select DM_GPIO
select DM_SPI
diff --git a/arch/sandbox/Kconfig b/arch/sandbox/Kconfig
index d4c1ee0..c931c0b 100644
--- a/arch/sandbox/Kconfig
+++ b/arch/sandbox/Kconfig
@@ -25,7 +25,4 @@ config PCI
used on some devices to allow the CPU to communicate with its
peripherals.
-config DM_KEYBOARD
- default y
-
endmenu
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 5193ee7..9207549 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -549,9 +549,6 @@ config I8254_TIMER
config I8042_KEYB
default y
-config DM_KEYBOARD
- default y
-
config SEABIOS
bool "Support booting SeaBIOS"
help
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner
2016-09-08 9:47 [U-Boot] [PATCH 1/2] sandbox, x86: select DM_KEYBOARD instead of default y entry Masahiro Yamada
@ 2016-09-08 9:47 ` Masahiro Yamada
2016-09-08 9:50 ` Marek Vasut
` (2 more replies)
2016-09-19 0:57 ` [U-Boot] [PATCH 1/2] sandbox, x86: select DM_KEYBOARD instead of default y entry Simon Glass
2016-10-03 13:36 ` [U-Boot] [U-Boot, " Tom Rini
2 siblings, 3 replies; 9+ messages in thread
From: Masahiro Yamada @ 2016-09-08 9:47 UTC (permalink / raw)
To: u-boot
Creating multiple entries of "config FOO" often gives us bad
experiences. In this case, we should specify "default X86"
as platforms that want this keyboard by default.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/x86/Kconfig | 3 ---
drivers/input/Kconfig | 1 +
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 9207549..ac2d598 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -546,9 +546,6 @@ config I8254_TIMER
Intel 8254 timer contains three counters which have fixed uses.
Include this to have U-Boot set up the timer correctly.
-config I8042_KEYB
- default y
-
config SEABIOS
bool "Support booting SeaBIOS"
help
diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig
index d560328..b3873c1 100644
--- a/drivers/input/Kconfig
+++ b/drivers/input/Kconfig
@@ -17,6 +17,7 @@ config CROS_EC_KEYB
config I8042_KEYB
bool "Enable Intel i8042 keyboard support"
depends on DM_KEYBOARD
+ default X86
help
This adds a driver for the i8042 keyboard controller, allowing the
keyboard to be used on devices which support this controller. The
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner
2016-09-08 9:47 ` [U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner Masahiro Yamada
@ 2016-09-08 9:50 ` Marek Vasut
2016-09-19 0:57 ` Simon Glass
2016-10-03 13:36 ` [U-Boot] [U-Boot, " Tom Rini
2 siblings, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2016-09-08 9:50 UTC (permalink / raw)
To: u-boot
On 09/08/2016 11:47 AM, Masahiro Yamada wrote:
> Creating multiple entries of "config FOO" often gives us bad
> experiences. In this case, we should specify "default X86"
> as platforms that want this keyboard by default.
Yep, I like this patch:
Acked-by: Marek Vasut <marex@denx.de>
btw on some of my computers , the 8042 is physically removable ;-)
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/x86/Kconfig | 3 ---
> drivers/input/Kconfig | 1 +
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 9207549..ac2d598 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -546,9 +546,6 @@ config I8254_TIMER
> Intel 8254 timer contains three counters which have fixed uses.
> Include this to have U-Boot set up the timer correctly.
>
> -config I8042_KEYB
> - default y
> -
> config SEABIOS
> bool "Support booting SeaBIOS"
> help
> diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig
> index d560328..b3873c1 100644
> --- a/drivers/input/Kconfig
> +++ b/drivers/input/Kconfig
> @@ -17,6 +17,7 @@ config CROS_EC_KEYB
> config I8042_KEYB
> bool "Enable Intel i8042 keyboard support"
> depends on DM_KEYBOARD
> + default X86
> help
> This adds a driver for the i8042 keyboard controller, allowing the
> keyboard to be used on devices which support this controller. The
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner
2016-09-08 9:47 ` [U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner Masahiro Yamada
2016-09-08 9:50 ` Marek Vasut
@ 2016-09-19 0:57 ` Simon Glass
2016-09-19 12:46 ` Masahiro Yamada
2016-10-03 13:36 ` [U-Boot] [U-Boot, " Tom Rini
2 siblings, 1 reply; 9+ messages in thread
From: Simon Glass @ 2016-09-19 0:57 UTC (permalink / raw)
To: u-boot
Hi Masahiro,
On 8 September 2016 at 03:47, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Creating multiple entries of "config FOO" often gives us bad
> experiences. In this case, we should specify "default X86"
> as platforms that want this keyboard by default.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/x86/Kconfig | 3 ---
> drivers/input/Kconfig | 1 +
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 9207549..ac2d598 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -546,9 +546,6 @@ config I8254_TIMER
> Intel 8254 timer contains three counters which have fixed uses.
> Include this to have U-Boot set up the timer correctly.
>
> -config I8042_KEYB
> - default y
> -
> config SEABIOS
> bool "Support booting SeaBIOS"
> help
> diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig
> index d560328..b3873c1 100644
> --- a/drivers/input/Kconfig
> +++ b/drivers/input/Kconfig
> @@ -17,6 +17,7 @@ config CROS_EC_KEYB
> config I8042_KEYB
> bool "Enable Intel i8042 keyboard support"
> depends on DM_KEYBOARD
> + default X86
What does this mean?
> help
> This adds a driver for the i8042 keyboard controller, allowing the
> keyboard to be used on devices which support this controller. The
> --
> 1.9.1
>
Regards,
Simon
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner
2016-09-19 0:57 ` Simon Glass
@ 2016-09-19 12:46 ` Masahiro Yamada
2016-09-23 4:16 ` Simon Glass
0 siblings, 1 reply; 9+ messages in thread
From: Masahiro Yamada @ 2016-09-19 12:46 UTC (permalink / raw)
To: u-boot
2016-09-19 9:57 GMT+09:00 Simon Glass <sjg@chromium.org>:
> Hi Masahiro,
>
> On 8 September 2016 at 03:47, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>> Creating multiple entries of "config FOO" often gives us bad
>> experiences. In this case, we should specify "default X86"
>> as platforms that want this keyboard by default.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> arch/x86/Kconfig | 3 ---
>> drivers/input/Kconfig | 1 +
>> 2 files changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 9207549..ac2d598 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -546,9 +546,6 @@ config I8254_TIMER
>> Intel 8254 timer contains three counters which have fixed uses.
>> Include this to have U-Boot set up the timer correctly.
>>
>> -config I8042_KEYB
>> - default y
>> -
>> config SEABIOS
>> bool "Support booting SeaBIOS"
>> help
>> diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig
>> index d560328..b3873c1 100644
>> --- a/drivers/input/Kconfig
>> +++ b/drivers/input/Kconfig
>> @@ -17,6 +17,7 @@ config CROS_EC_KEYB
>> config I8042_KEYB
>> bool "Enable Intel i8042 keyboard support"
>> depends on DM_KEYBOARD
>> + default X86
>
> What does this mean?
The default value of I8042_KEYB is the
value of X86.
In another expression,
default y if X86
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 9+ messages in thread* [U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner
2016-09-19 12:46 ` Masahiro Yamada
@ 2016-09-23 4:16 ` Simon Glass
0 siblings, 0 replies; 9+ messages in thread
From: Simon Glass @ 2016-09-23 4:16 UTC (permalink / raw)
To: u-boot
On 19 September 2016 at 06:46, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> 2016-09-19 9:57 GMT+09:00 Simon Glass <sjg@chromium.org>:
>> Hi Masahiro,
>>
>> On 8 September 2016 at 03:47, Masahiro Yamada
>> <yamada.masahiro@socionext.com> wrote:
>>> Creating multiple entries of "config FOO" often gives us bad
>>> experiences. In this case, we should specify "default X86"
>>> as platforms that want this keyboard by default.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> ---
>>>
>>> arch/x86/Kconfig | 3 ---
>>> drivers/input/Kconfig | 1 +
>>> 2 files changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>>> index 9207549..ac2d598 100644
>>> --- a/arch/x86/Kconfig
>>> +++ b/arch/x86/Kconfig
>>> @@ -546,9 +546,6 @@ config I8254_TIMER
>>> Intel 8254 timer contains three counters which have fixed uses.
>>> Include this to have U-Boot set up the timer correctly.
>>>
>>> -config I8042_KEYB
>>> - default y
>>> -
>>> config SEABIOS
>>> bool "Support booting SeaBIOS"
>>> help
>>> diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig
>>> index d560328..b3873c1 100644
>>> --- a/drivers/input/Kconfig
>>> +++ b/drivers/input/Kconfig
>>> @@ -17,6 +17,7 @@ config CROS_EC_KEYB
>>> config I8042_KEYB
>>> bool "Enable Intel i8042 keyboard support"
>>> depends on DM_KEYBOARD
>>> + default X86
>>
>> What does this mean?
>
>
> The default value of I8042_KEYB is the
> value of X86.
>
>
> In another expression,
>
> default y if X86
Ah OK, thanks.
Reviewed-by: Simon Glass <sjg@chromium.org>
Regards,
Simon
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [U-Boot, 2/2] input: specify the default of I8042_KEYB in more correct manner
2016-09-08 9:47 ` [U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner Masahiro Yamada
2016-09-08 9:50 ` Marek Vasut
2016-09-19 0:57 ` Simon Glass
@ 2016-10-03 13:36 ` Tom Rini
2 siblings, 0 replies; 9+ messages in thread
From: Tom Rini @ 2016-10-03 13:36 UTC (permalink / raw)
To: u-boot
On Thu, Sep 08, 2016 at 06:47:36PM +0900, Masahiro Yamada wrote:
> Creating multiple entries of "config FOO" often gives us bad
> experiences. In this case, we should specify "default X86"
> as platforms that want this keyboard by default.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161003/dc9447fe/attachment.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/2] sandbox, x86: select DM_KEYBOARD instead of default y entry
2016-09-08 9:47 [U-Boot] [PATCH 1/2] sandbox, x86: select DM_KEYBOARD instead of default y entry Masahiro Yamada
2016-09-08 9:47 ` [U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner Masahiro Yamada
@ 2016-09-19 0:57 ` Simon Glass
2016-10-03 13:36 ` [U-Boot] [U-Boot, " Tom Rini
2 siblings, 0 replies; 9+ messages in thread
From: Simon Glass @ 2016-09-19 0:57 UTC (permalink / raw)
To: u-boot
On 8 September 2016 at 03:47, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Once we migrate to DM-based drivers, we cannot go back to legacy
> ones, i.e. config options like DM_* are not user-configurable.
>
> Make SANDBOX and X86 select DM_KEYBOARD like other platforms do.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/Kconfig | 2 ++
> arch/sandbox/Kconfig | 3 ---
> arch/x86/Kconfig | 3 ---
> 3 files changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [U-Boot, 1/2] sandbox, x86: select DM_KEYBOARD instead of default y entry
2016-09-08 9:47 [U-Boot] [PATCH 1/2] sandbox, x86: select DM_KEYBOARD instead of default y entry Masahiro Yamada
2016-09-08 9:47 ` [U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner Masahiro Yamada
2016-09-19 0:57 ` [U-Boot] [PATCH 1/2] sandbox, x86: select DM_KEYBOARD instead of default y entry Simon Glass
@ 2016-10-03 13:36 ` Tom Rini
2 siblings, 0 replies; 9+ messages in thread
From: Tom Rini @ 2016-10-03 13:36 UTC (permalink / raw)
To: u-boot
On Thu, Sep 08, 2016 at 06:47:35PM +0900, Masahiro Yamada wrote:
> Once we migrate to DM-based drivers, we cannot go back to legacy
> ones, i.e. config options like DM_* are not user-configurable.
>
> Make SANDBOX and X86 select DM_KEYBOARD like other platforms do.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161003/795bd0f0/attachment.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-10-03 13:36 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-08 9:47 [U-Boot] [PATCH 1/2] sandbox, x86: select DM_KEYBOARD instead of default y entry Masahiro Yamada
2016-09-08 9:47 ` [U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner Masahiro Yamada
2016-09-08 9:50 ` Marek Vasut
2016-09-19 0:57 ` Simon Glass
2016-09-19 12:46 ` Masahiro Yamada
2016-09-23 4:16 ` Simon Glass
2016-10-03 13:36 ` [U-Boot] [U-Boot, " Tom Rini
2016-09-19 0:57 ` [U-Boot] [PATCH 1/2] sandbox, x86: select DM_KEYBOARD instead of default y entry Simon Glass
2016-10-03 13:36 ` [U-Boot] [U-Boot, " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox